This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
[1LP][RFR] Fix minor version update tests. #8521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarovo
changed the title
|
@JaryN Please check PRT failures |
lina-is-here
changed the title
dajoRH
added
needs-rebase
needs-lint
lint-ok
and removed
needs-rebase
lint-ok
needs-lint
labels
dajoRH
added
needs-lint
lint-ok
needs-rebase
and removed
lint-ok
needs-lint
needs-rebase
labels
added 28 commits
August 2, 2019 16:19
The repo file (for example http://file.cloudforms.lab.eng.rdu2.redhat.com/builds/cfme/5.10/5.10.3.1/packages.repo ) contains link to baseurl with dir `latest`. But not every time we have picked the latest package.repo. In such case the package refered in `latest` dir will not be the intended one and it is better to detect that. This patch adds a method for checking the version of cfme the packages.repo in the end ponts at.
After the db migration and evm restart of the cfme/tests/test_db_migrate.py::test_db_migrate_replication[57] and other tests with similar pattern, the login page is not fully loaded immediately and needs some time to display all the components. If not waited for, the test dies with: Exception: Could not open the login screen. Adding simple wait_for helps to wait until the login page load.
This should help with test_update_ha_webui
This is fixing
@Property
def is_dedicated_active(self):
result = self.appliance.ssh_client.run_command(
"systemctl status {}-postgresql.service | grep running".format(
> self.postgres_version))
E AttributeError: 'ApplianceDB' object has no attribute 'postgres_version'
|
Test fixes will be addressed in a different PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In general this PR makes minor version update tests working.
Note for 2LP: It is probably futile, but would prefer to not squash the commits on approve to keep the track of what line changed for what reason.
them (possibly incorrect one) was selected by the tests. This PR
tries to select the the correct rest-api object matching the appliance
in the context.
This needs #8749
Tested already with: py.test: -v cfme/tests/cli/test_appliance_update.py
{{ py.test: -v cfme/tests/generic_objects/test_instances.py }}