Skip to content
This repository has been archived by the owner on Apr 7, 2022. It is now read-only.

[WIP] Fix DST problem in schedule tests. #8555

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[WIP] Fix DST problem in schedule tests. #8555

wants to merge 1 commit into from

Conversation

jarovo
Copy link
Contributor

@jarovo jarovo commented Mar 7, 2019

Purpose or Intent

The DST transition in March causes the tests failing because the time the appliance is shifted to is mismatching the time of the upcoming schedule.

{py.test: -v cfme/tests/configure/test_schedule_operations.py}

@dajoRH
Copy link
Contributor

dajoRH commented Mar 7, 2019

Lint report for commit 08b62a3:

cfme/tests/configure/test_schedule_operations.py:

  • ‼️ Line 53:5: E265 block comment should start with '# '
  • ‼️ Line 63:14: E222 multiple spaces after operator
  • ‼️ Line 71:14: E222 multiple spaces after operator
  • ‼️ Line 232:101: E501 line too long (108 > 100 characters)
  • ‼️ Line 234:13: E126 continuation line over-indented for hanging indent

Hmmm
😱 You might like to check the lint of your code ☝️

No commit flaws detected.

CFME QE Bot

@dajoRH
Copy link
Contributor

dajoRH commented Apr 5, 2019

Would you mind rebasing this Pull Request against latest master, please? :trollface:
CFME QE Bot

@dajoRH
Copy link
Contributor

dajoRH commented Aug 7, 2019

I detected some fixture changes in commit 08b62a3

The local fixture current_server_time is used in the following files:

  • cfme/tests/configure/test_schedule_operations.py
    • test_schedule_crud
    • test_schedule_analysis_in_the_past
    • test_inactive_schedule

Please, consider creating a PRT run against these tests make sure your fixture changes do not break existing usage 😃

@dajoRH dajoRH changed the title [WIPTEST] Fix DST problem in schedule tests. [WIP] Fix DST problem in schedule tests. Aug 13, 2019
@dajoRH dajoRH added WIP and removed WIP-testing labels Aug 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants