[WIP] Updating CRUD operations test for automate method #8876

ganeshhubale · 2019-05-28T14:01:22Z

PRT RUN

{{ pytest: cfme/tests/automate/test_method.py::test_method_crud -vv }}

john-dupuy

A few questions, overall looking really nice! 👍

cfme/automate/explorer/method.py

john-dupuy · 2019-08-23T18:52:54Z

cfme/automate/explorer/method.py

-            return self.parent_obj.tree_path + [
-                (icon_name_map[self.location.lower()], '{} ({})'.format(self.display_name,
-                                                                        self.name))]
+            if self.location in ['Ansible Tower Job Template', 'Ansible Tower Workflow Template']:


Thoughts on making this strings class level or module level attributes? That way if they need to be updated, you will only have to update them there.

Hey John,

I am not getting what you actually want here. Do you want me to create global list of locations?

Please explain more and give me example.

@ganeshhubale sorry for delayed reply, I must've missed this. Yeah, I was suggesting that you make global list lof locations, something like:

LOCATIONS = ['Ansible Tower Job Template', 'Ansible Tower Workflow Template']

Got it @john-dupuy
I will update with this change.

cfme/tests/automate/test_method.py

sshveta · 2020-01-13T20:36:53Z

cfme/automate/explorer/method.py

+            })
+            validate = False
+
+        if location == 'Ansible Tower Job Template':


I don't see any difference in add_page.fill for both the locations , why do we need if checks ?

sshveta · 2020-01-14T16:23:11Z

cfme/automate/explorer/method.py

@@ -484,6 +507,15 @@ def create(
                'playbook_input_parameters': playbook_input_parameters
            })
            validate = False
+
+        if location in ['Ansible Tower Workflow Template', 'Ansible Tower Job Template']:


if location in self.LOCATIONS:

I think location is fine there, no need for self as location is an argument in create.

Yup that was a typo :)

sshveta · 2020-01-14T16:24:27Z

cfme/automate/explorer/method.py

+                'method_display_name': display_name,
+                'ansible_max_ttl': max_ttl,
+            })
+            validate = False


Why are you setting validate=false here ?
Don't we need to validate after fillng data ?

@sshveta For method types such as 'Ansible Tower Workflow Template', 'Ansible Tower Job Template', 'playbook'; we don't have such feature with button validate. This is applicable only for inline type of method.

sshveta · 2020-01-14T16:25:41Z

cfme/automate/explorer/method.py

        )


 class Method(BaseEntity, Copiable):

+    LOCATIONS = ['Ansible Tower Job Template', 'Ansible Tower Workflow Template']


Thoughts on making it global so that you can import it in test file too ?

john-dupuy

One question, thanks for this PR @ganeshhubale

john-dupuy · 2020-01-16T20:08:17Z

cfme/automate/explorer/method.py

    save_button = Button('Save')
    reset_button = Button('Reset')
    cancel_button = Button('Cancel')

    def before_fill(self, values):
        location = self.context['object'].location.lower()
-        if 'display_name' in values and location in ['inline', 'playbook']:
-            values['{}_display_name'.format(location)] = values['display_name']
+        if 'display_name' in values:


@ganeshhubale What about the playbook case? Won't this fail if location=='playbook'?

Hey @john-dupuy
Actually I am not getting why this question. So I tested test_automate_ansible_playbook_method_type_crud < this test case with these changes locally. And it works as expected.

@ganeshhubale I have some test that uses this method that has failed in this section of code before. I remember I had to add in the location in ['inline', 'playbook'] line to get it to work. Can you please try running test_alert_run_ansible_playbook?

My point is that you've removed the code that handles the case where location == 'playbook'. I.e. to keep the original code intact, L324 should be

if location in ['inline', 'playbook']:

Does that make sense? Or am I missing something here?

john-dupuy · 2020-01-16T20:09:17Z

cfme/automate/explorer/method.py

-        elif 'name' in values and location in ['inline', 'playbook']:
-            values['{}_name'.format(location)] = values['name']
+
+        elif 'name' in values:


Same question here about playbook case.

Signed-off-by: Ganesh Hubale <[email protected]>

dajoRH · 2020-01-21T06:40:21Z

I detected some fixture changes in commit 554ce24

The local fixture original_class is used in the following files:

cfme/tests/automate/test_method.py
- test_automate_simulate_retry

Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃

dajoRH · 2020-03-31T15:50:05Z

Would you mind rebasing this Pull Request against latest master, please?
CFME QE Bot

dajoRH added lint-ok WIP needs-rebase labels May 28, 2019

ganeshhubale changed the title ~~[WIP] Updating CRUD operations test for automate method~~ [WIPTEST] Updating CRUD operations test for automate method Aug 19, 2019

dajoRH changed the title ~~[WIPTEST] Updating CRUD operations test for automate method~~ [WIP] Updating CRUD operations test for automate method Aug 19, 2019

dajoRH added WIP-testing WIP and removed WIP WIP-testing labels Aug 19, 2019

ganeshhubale force-pushed the automate-method-crud branch from c8d1e4b to cb9e527 Compare August 19, 2019 10:32

ganeshhubale changed the title ~~[WIP] Updating CRUD operations test for automate method~~ [WIPTEST] Updating CRUD operations test for automate method Aug 19, 2019

ganeshhubale force-pushed the automate-method-crud branch from cb9e527 to 4c5c16e Compare August 19, 2019 10:42

dajoRH added WIP-testing and removed needs-rebase WIP labels Aug 19, 2019

ganeshhubale force-pushed the automate-method-crud branch 3 times, most recently from fe04e8b to 8f0240e Compare August 23, 2019 11:20

ganeshhubale changed the title ~~[WIPTEST] Updating CRUD operations test for automate method~~ [RFR] Updating CRUD operations test for automate method Aug 23, 2019

dajoRH removed the WIP-testing label Aug 23, 2019

john-dupuy suggested changes Aug 23, 2019

View reviewed changes

digitronik added the enhancement label Aug 26, 2019

john-dupuy changed the title ~~[RFR] Updating CRUD operations test for automate method~~ [WIPTEST] Updating CRUD operations test for automate method Aug 27, 2019

dajoRH added the WIP-testing label Aug 27, 2019

dajoRH changed the title ~~[WIPTEST] Updating CRUD operations test for automate method~~ [WIP] Updating CRUD operations test for automate method Sep 4, 2019

dajoRH added needs-rebase WIP and removed WIP-testing labels Sep 4, 2019

ganeshhubale changed the title ~~[WIP] Updating CRUD operations test for automate method~~ [WIPTEST] Updating CRUD operations test for automate method Sep 13, 2019

ganeshhubale force-pushed the automate-method-crud branch from 8f0240e to 9287043 Compare September 13, 2019 10:55

dajoRH added WIP-testing and removed needs-rebase WIP labels Sep 13, 2019

ganeshhubale force-pushed the automate-method-crud branch 2 times, most recently from 1297b8d to cf1c4a4 Compare September 16, 2019 10:21

ganeshhubale force-pushed the automate-method-crud branch 3 times, most recently from b9ac4b1 to 39c021f Compare September 23, 2019 12:52

ganeshhubale force-pushed the automate-method-crud branch from 39c021f to 874d1af Compare October 15, 2019 06:02

ganeshhubale force-pushed the automate-method-crud branch from 874d1af to 567807f Compare October 22, 2019 11:26

ganeshhubale force-pushed the automate-method-crud branch from 567807f to 4db6bfe Compare December 2, 2019 07:03

ganeshhubale force-pushed the automate-method-crud branch from 4db6bfe to 6d8bb3f Compare January 13, 2020 10:35

ganeshhubale changed the title ~~[WIPTEST] Updating CRUD operations test for automate method~~ [RFR] Updating CRUD operations test for automate method Jan 13, 2020

dajoRH removed the WIP-testing label Jan 13, 2020

sshveta suggested changes Jan 13, 2020

View reviewed changes

ganeshhubale force-pushed the automate-method-crud branch 2 times, most recently from 0121113 to 36b5905 Compare January 14, 2020 07:07

sshveta suggested changes Jan 14, 2020

View reviewed changes

john-dupuy suggested changes Jan 16, 2020

View reviewed changes

john-dupuy changed the title ~~[RFR] Updating CRUD operations test for automate method~~ [WIPTEST] Updating CRUD operations test for automate method Jan 16, 2020

dajoRH added the WIP-testing label Jan 16, 2020

Ganesh Hubale added 2 commits January 21, 2020 11:02

Adding CRUD operations for automate method

74458f1

updated with requested changes

554ce24

Signed-off-by: Ganesh Hubale <[email protected]>

ganeshhubale force-pushed the automate-method-crud branch from 36b5905 to 554ce24 Compare January 21, 2020 05:47

dajoRH changed the title ~~[WIPTEST] Updating CRUD operations test for automate method~~ [WIP] Updating CRUD operations test for automate method Mar 31, 2020

dajoRH added the needs-rebase label Mar 31, 2020

dajoRH added WIP and removed WIP-testing labels Mar 31, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Updating CRUD operations test for automate method #8876

[WIP] Updating CRUD operations test for automate method #8876

ganeshhubale commented May 28, 2019 •

edited

Loading

john-dupuy left a comment

john-dupuy Aug 23, 2019

ganeshhubale Sep 13, 2019

john-dupuy Sep 23, 2019

ganeshhubale Sep 23, 2019

sshveta Jan 13, 2020

sshveta Jan 14, 2020 •

edited

Loading

kedark3 Jan 14, 2020

sshveta Jan 14, 2020

sshveta Jan 14, 2020

ganeshhubale Jan 21, 2020

sshveta Jan 14, 2020

john-dupuy left a comment

john-dupuy Jan 16, 2020

ganeshhubale Jan 21, 2020

john-dupuy Jan 21, 2020

john-dupuy Jan 16, 2020

dajoRH commented Jan 21, 2020

dajoRH commented Mar 31, 2020

[WIP] Updating CRUD operations test for automate method #8876

Are you sure you want to change the base?

[WIP] Updating CRUD operations test for automate method #8876

Conversation

ganeshhubale commented May 28, 2019 • edited Loading

PRT RUN

john-dupuy left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sshveta Jan 14, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

john-dupuy left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dajoRH commented Jan 21, 2020

dajoRH commented Mar 31, 2020

ganeshhubale commented May 28, 2019 •

edited

Loading

sshveta Jan 14, 2020 •

edited

Loading