[WIP] Dockerize for dev #8911
[WIP] Dockerize for dev #8911
Conversation
mshriver
force-pushed
the
dockerize-for-dev
branch
from
0df216f to
952e666
Compare
mshriver
force-pushed
the
dockerize-for-dev
branch
from
952e666 to
bd9133a
Compare
mshriver
force-pushed
the
dockerize-for-dev
branch
from
8520370 to
2e55553
Compare
| @@ -21,7 +21,7 @@ | |||
|
|
|||
| pytestmark = [ | |||
| test_requirements.rbac, | |||
| pytest.mark.provider(classes=[VMwareProvider], selector=ONE), | |||
| pytest.mark.provider(classes=[RHEVMProvider], selector=ONE), | |||
There was a problem hiding this comment.
QUESTION Why was this changed?
| @@ -0,0 +1,27 @@ | |||
| # Intended build context is integration_tests top level | |||
|
|
|||
| FROM sel-browsers:latest | |||
There was a problem hiding this comment.
Is this custom built container?
|
|
||
| EXPOSE 5999 | ||
|
|
||
| ENTRYPOINT ["/entrypoint"] |
There was a problem hiding this comment.
If I were to run this, how would I build and invoke the container? And I see this is for dev but what if I want to run against regular appliance? Do we have container for that?
There was a problem hiding this comment.
Reason I ask this is that, all of us have different way to setup and run the tests, I use selenium container for browser, some use local browser installed on their system, etc. What would be a way to unify that and make it such that all of QE team can standardize on a container image that acts as test env for them, includes right dependencies and browsers. We then can rebuild that as needed and team won't need to fix their env, just pull latest docker image? I'm sure you must have thought about it. Have you?
squashed commit messages from Jason Frey: Update docker container with more browsers and reorganize Some changes to get older firefox working Change matplotlib to be a separate binary install step. Allow entrypoint script to accept params. Ensure host.docker.internal exists copy frozen.txt from the local clone of the code Add basic directions for running the docker container Use new frozen.py2.txt instead
pytest_store handling of no SSH client address dockerignore for pytest_cache iputils and iproute in quickstart system packages SSHDummy property handling, explicitly None building cfme-tests docker on cfmeqe_sel_stable
mshriver
force-pushed
the
dockerize-for-dev
branch
from
2e55553 to
28e0f98
Compare
|
Would you mind rebasing this Pull Request against latest master, please? |
Building on @Fryguy work to create single dockerfile for vnc+pytest env with mounted tests.
Handling SSH for dev appliances in a clean way in framework/tests.
Fixing framework pieces around dev appliances.