[WIP] Adding test coverage #9085
Conversation
apagac
force-pushed
the
another_qe_coverage
branch
from
4137261 to
a04cedf
Compare
| 1. Snapshot not created; 'Required' displayed | ||
| 2. Snapshot created successfully | ||
| Bugzilla: | ||
| 1647916 |
There was a problem hiding this comment.
@apagac since you are putting in the BZ metadata, can you also add it to the top of the file?
@pytest.mark.meta(coverage=[<bug_id>])
There was a problem hiding this comment.
and the same for other tests
|
|
||
| @pytest.mark.manual | ||
| @pytest.mark.provider([OpenStackProvider]) | ||
| @test_requirements.snapshot |
There was a problem hiding this comment.
All tests in this module have the same requirement, so please put it for the whole module
pytestmark = [test_requirements.snapshot]
There was a problem hiding this comment.
@lina-nikiforova some have rbac and auth
There was a problem hiding this comment.
Oh but they are different files, please ignore above 🤦♂️
|
|
||
|
|
||
| @pytest.mark.manual | ||
| @test_requirements.rbac |
There was a problem hiding this comment.
same here for the requirements, I think it's better to define at the module level
| @pytest.mark.tier(2) | ||
| def test_create_higher_permission(): | ||
| """ | ||
| Test creating a group with higher permission that the user currently has. |
There was a problem hiding this comment.
Is it the correct description? I don't see group creation in the test steps...
|
|
||
|
|
||
| @pytest.mark.manual | ||
| @test_requirements.auth |
There was a problem hiding this comment.
Same for the requirements as above
|
Would you mind rebasing this Pull Request against latest master, please? |
Adding test coverage for BZs with test_coverage_flag.
Also removed
test_osp_snapshot_buttonswhich is no longer relevant. Dev choose different approach.