[1LP][RFR] Conversion of ConfigManager to use BaseProvider and BaseCollection

[john-dupuy]

Converting config manager (i.e. Satellite and Ansible Tower Providers) to use BaseProvider and BaseCollection. This is an initial stab in order to get these providers up to speed with the rest of the framework.

With this enhancement, we'll be able to parametrize tests against config management providers in the same way that we parametrize tests against normal providers.

In addition to updating config managers to use BaseEntity and BaseCollection this pr also

1. Removes duplicate ansible tower code, the entry_point for the ansible_tower_providers collection is now provided by cfme.infrastructure.config_management.ansible_tower
2. Removes the test generation for config managers. This is now replaced by the stander pytest.mark.provider([AnsibleTowerProvider, SatelliteProvider])
3. Added ConfigProfiles as a subcollection for ConfigManagers
4. Added ConfigSystems as a subcollection for ConfigProfiles

Requires yaml MR 864 -> this MR brings in updates to our yamls so that the config managers are considered as normal providers.

Note PRT will fail due to the yaml update requirement. For test results search for the jenkin's job jdupuy-pr-9317-510z.

{{ pytest: --long-running cfme/tests/infrastructure/test_config_management.py cfme/tests/infrastructure/test_config_management_rest.py cfme/tests/services/test_config_provider_servicecatalogs.py cfme/tests/services/test_ansible_workflow_servicecatalogs.py
}}

[john-dupuy]

@nachandr I'd like your input on what I've done here. It is a pretty major refactor on the configuration management code.

[john-dupuy]

PRT failures do not appear to be the result of these changes, marking RFR.

[lina-is-here]

@john-dupuy please resolve the conflicts

[mshriver]

Couple small changes across the test modules and framework modules.

Want to see resolution to some of the PRT failures for AttributeError on the collection name, and handling of the object used for navigation (property object has no attribute server)

[digitronik]

LGTM 👍

[digitronik]

return if self.manager.type == "ansible_tower" else ""Configuration Profile""

[digitronik]

If no destination available then better to remove this still we will get proper error msg.

[john-dupuy]

            "There is no page in MIQ that displays all config managers."
            " Use 'AllOfType' on a config manager provider instance."
        )

The error message I provided provides some extra details about what you should do instead. Do you think we should remove that additional info?

[mshriver]

Mixed feelings - but I do appreciate the extra context provided by the exception here.

I think if it stays, it should raise navmazing.NavigationDestinationNotFound instead of NotImplementedError.

[john-dupuy]

Modified to raise NavigationDestinationNotFound

[mshriver]

Good - I'm willing to accept as some 'tech-debt' to just remove it once callers are familiar with new structure and definition.

[dajoRH]

I detected some fixture changes in commit 6ec5f9b

Show fixtures

The local fixture config_system is used in the following files:

• cfme/tests/infrastructure/test_config_management.py
  • test_config_system_tag
  • test_config_system_reprovision

The local fixture authentications is used in the following files:

• cfme/tests/infrastructure/test_config_management_rest.py
  • _check_edited_authentications
  • test_query_authentications_attributes
  • test_authentications_edit_single
  • test_authentications_edit_multiple
  • test_delete_authentications_from_detail_post
  • test_delete_authentications_from_detail_delete
  • test_delete_authentications_from_collection

The local fixture config_manager_rest is used in the following files:

• cfme/tests/infrastructure/test_config_management_rest.py
  • test_config_manager_create_rest
  • test_config_manager_edit_rest
  • test_config_manager_delete_rest

The local fixture ansible_workflow_catitem is used in the following files:

• cfme/tests/services/test_ansible_workflow_servicecatalogs.py
  • test_tower_workflow_item
  • test_retire_ansible_workflow

The local fixture catalog_item is used in the following files:

• cfme/tests/services/test_config_provider_servicecatalogs.py
  • test_order_tower_catalog_item
  • test_retire_ansible_service

Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃

[jawatts]

Results from jenkins run look good. Any test failures will be handled in separate PRs.