This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
[NOTEST][WIP]initial commit with vault+sprout integration via dynaconf #9402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kedark3
force-pushed
the
sprout_vault
branch
2 times, most recently
from
fbaf419 to
288dbd1
Compare
izapolsk
reviewed
Nov 8, 2019
| """Log into Vault, renew the token, and return the Vault client""" | ||
| vault = Client(url=url, token=token, verify=False) | ||
| if not vault.is_authenticated(): | ||
| return None |
There was a problem hiding this comment.
shouldn't it login in this case ?
| from dynaconf import LazySettings | ||
| from hvac import Client | ||
|
|
||
| VAULT_APPROLE = 'cfme-qe-infra' |
There was a problem hiding this comment.
I'd turn all this stuff into class
| # and VAULT_SKIP_VERIFY=true to disable ssl verification | ||
|
|
||
| echo 'login with kerberos - make sure you are admin by reading listed policies' | ||
| vault login -method=ldap -tls-skip-verify=true username=<user> |
There was a problem hiding this comment.
shouldn't it ask for this value or look for it in env variables ?
| from cfme.utils.log import logger | ||
| from sprout.vault.vault import settings | ||
|
|
||
| providers_data = conf.cfme_data.get("management_systems", {}) |
There was a problem hiding this comment.
sprout is deployed along with test framework. do we really need to add it's own providers and vault files ?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose or Intent