[1LP][RFR] Embedded Ansible service to check "Cloud Credentials" used in the service. #9414

sbulage · 2019-09-26T09:01:21Z

Purpose or Intent

Automated manual tests which has BZ associated with it.

PRT Run

{{pytest: cfme/tests/ansible/test_embedded_ansible_services.py -k "test_ansible_service_cloud_credentials" --long-running --use-provider=complete -svvvv }}

sbulage · 2019-09-26T09:19:20Z

cfme/tests/ansible/test_embedded_ansible_services.py

+            }
+
+        service = MyService(appliance, ansible_catalog_item.name)
+        if service_request.exists():


Comment for reviewers: This tear down is already written in funcscope fixture, in this PR #9194

sshveta · 2019-09-26T16:16:32Z

cfme/tests/ansible/test_embedded_ansible_services.py

+
+    @request.addfinalizer
+    def _revert():
+        with update(ansible_catalog_item):


Why is this required ? The ansible_catalog_item fixture is deleting the catalog item after yield .
https://github.com/ManageIQ/integration_tests/blob/master/cfme/fixtures/ansible_fixtures.py#L81

ansible_catalog_item fixture will be used in different tests. So, resetting back to default values to use it as default fixture for next tests.

I don't think this is a good practice, as if this fails it will potentially impact all following test cases, and be difficult to debug. If you are modifying the catalog item, it should be made function scoped, at least for this test case.

@mshriver This will impact on Over all tests execution in terms of time. Also, in most of the tests ansible_catalog_tem is being modified to use another playbook. Does that makes sense.?

@mshriver This PR --> #9490 will take care of this.

Also, will push changes to #9490

cfme/tests/ansible/test_embedded_ansible_services.py

sshveta · 2019-10-01T17:48:26Z

cfme/tests/ansible/test_embedded_ansible_services.py

+    "credential", CREDENTIALS, ids=[cred[0] for cred in CREDENTIALS]
+)
+@pytest.mark.provider(
+    [RHEVMProvider, EC2Provider, VMwareProvider, AzureProvider], selector=ONE_PER_TYPE


Can we do pytest.mark.provider([InfraProvider, cloudProvider], selector=ONE_PER_TYPE) ?
If all providers are eligible

@sshveta I am uncollecting other providers because of Playbooks. Once I will add playbooks for other Providers like OSP, I will Add Marker to collect all Providers.

Please add in-line comment/TODO for why specific providers are collected.

@mshriver I will add TODO/Comment in the #9076 after merge of it.

Added Comment/TODO for other providers.

mshriver

Module scoped catalog item instance needs to be treated differently if we're modifying it within test functions.

dajoRH · 2019-10-16T14:38:31Z

I detected some fixture changes in commit 68f7999

The local fixture provider_credentials is used in the following files:

cfme/tests/ansible/test_embedded_ansible_services.py

Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃

… in the service. (ManageIQ#9414) * Removed manual tests. * Added automation for BZ 1444092. * Added one more manual tests. * Updated new RHV playbook and added TODO.

sbulage force-pushed the ansible_automate_BZ1444092 branch from fb35bc6 to c0a389e Compare September 26, 2019 09:02

dajoRH added lint-ok WIP-testing labels Sep 26, 2019

sbulage commented Sep 26, 2019

View reviewed changes

sbulage changed the title ~~[WIPTEST] Embedded Ansible service to check "Cloud Credentials" used in the service.~~ [RFR] Embedded Ansible service to check "Cloud Credentials" used in the service. Sep 26, 2019

dajoRH removed the WIP-testing label Sep 26, 2019

valaparthvi added the new-test-or-feature label Sep 26, 2019

sshveta suggested changes Sep 26, 2019

View reviewed changes

sshveta changed the title ~~[RFR] Embedded Ansible service to check "Cloud Credentials" used in the service.~~ [WIPTEST] Embedded Ansible service to check "Cloud Credentials" used in the service. Sep 26, 2019

dajoRH added the WIP-testing label Sep 26, 2019

dajoRH changed the title ~~[WIPTEST] Embedded Ansible service to check "Cloud Credentials" used in the service.~~ [WIP] Embedded Ansible service to check "Cloud Credentials" used in the service. Sep 26, 2019

dajoRH added needs-rebase WIP and removed WIP-testing labels Sep 26, 2019

sbulage force-pushed the ansible_automate_BZ1444092 branch from c0a389e to 8a39f98 Compare September 30, 2019 09:21

dajoRH removed the needs-rebase label Sep 30, 2019

sbulage changed the title ~~[WIP] Embedded Ansible service to check "Cloud Credentials" used in the service.~~ [WIPTEST] Embedded Ansible service to check "Cloud Credentials" used in the service. Sep 30, 2019

dajoRH added WIP-testing and removed WIP labels Sep 30, 2019

sbulage force-pushed the ansible_automate_BZ1444092 branch from 8a39f98 to 7b1fa88 Compare September 30, 2019 10:18

sbulage changed the title ~~[WIPTEST] Embedded Ansible service to check "Cloud Credentials" used in the service.~~ [RFR] Embedded Ansible service to check "Cloud Credentials" used in the service. Oct 1, 2019

dajoRH removed the WIP-testing label Oct 1, 2019

izapolsk self-requested a review October 1, 2019 12:51

sshveta reviewed Oct 1, 2019

View reviewed changes

sshveta approved these changes Oct 2, 2019

View reviewed changes

sshveta changed the title ~~[RFR] Embedded Ansible service to check "Cloud Credentials" used in the service.~~ [1LP][RFR] Embedded Ansible service to check "Cloud Credentials" used in the service. Oct 2, 2019

mshriver added test-automation To be applied on PR's which are automating existing manual cases and removed new-test-or-feature labels Oct 2, 2019

mshriver suggested changes Oct 2, 2019

View reviewed changes

mshriver changed the title ~~[1LP][RFR] Embedded Ansible service to check "Cloud Credentials" used in the service.~~ [1LP][WIPTEST] Embedded Ansible service to check "Cloud Credentials" used in the service. Oct 2, 2019

sbulage changed the title ~~[1LP][WIPTEST] Embedded Ansible service to check "Cloud Credentials" used in the service.~~ [1LP][RFR] Embedded Ansible service to check "Cloud Credentials" used in the service. Oct 3, 2019

sbulage changed the title ~~[1LP][RFR] Embedded Ansible service to check "Cloud Credentials" used in the service.~~ [1LP][WIPTEST] Embedded Ansible service to check "Cloud Credentials" used in the service. Oct 3, 2019

sbulage mentioned this pull request Oct 7, 2019

[RFR] Updated RHV playbook. ManageIQ/integration_tests_playbooks#6

Merged

dajoRH added the WIP-testing label Oct 9, 2019

sbulage force-pushed the ansible_automate_BZ1444092 branch from e4d0c4a to a13c08e Compare October 13, 2019 09:36

sbulage changed the title ~~[1LP][WIPTEST] Embedded Ansible service to check "Cloud Credentials" used in the service.~~ [1LP][RFR] Embedded Ansible service to check "Cloud Credentials" used in the service. Oct 13, 2019

dajoRH removed the WIP-testing label Oct 13, 2019

izapolsk changed the title ~~[1LP][RFR] Embedded Ansible service to check "Cloud Credentials" used in the service.~~ [1LP][WIP] Embedded Ansible service to check "Cloud Credentials" used in the service. Oct 16, 2019

dajoRH added needs-rebase WIP labels Oct 16, 2019

sbulage added 4 commits October 16, 2019 19:49

Removed manual tests.

a5118f7

Added automation for BZ 1444092.

15b9470

Added one more manual tests.

5d398af

Updated new RHV playbook and added TODO.

68f7999

sbulage force-pushed the ansible_automate_BZ1444092 branch from a13c08e to 68f7999 Compare October 16, 2019 14:31

sbulage changed the title ~~[1LP][WIP] Embedded Ansible service to check "Cloud Credentials" used in the service.~~ [1LP][WIPTEST] Embedded Ansible service to check "Cloud Credentials" used in the service. Oct 16, 2019

dajoRH added WIP-testing and removed needs-rebase WIP labels Oct 16, 2019

sbulage changed the title ~~[1LP][WIPTEST] Embedded Ansible service to check "Cloud Credentials" used in the service.~~ [1LP][RFR] Embedded Ansible service to check "Cloud Credentials" used in the service. Oct 16, 2019

dajoRH removed the WIP-testing label Oct 16, 2019

izapolsk added the tech-debt label Oct 17, 2019

izapolsk approved these changes Oct 17, 2019

View reviewed changes

izapolsk merged commit a663c05 into ManageIQ:master Oct 17, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[1LP][RFR] Embedded Ansible service to check "Cloud Credentials" used in the service. #9414

[1LP][RFR] Embedded Ansible service to check "Cloud Credentials" used in the service. #9414

sbulage commented Sep 26, 2019

sbulage Sep 26, 2019

sshveta Sep 26, 2019

sbulage Sep 26, 2019

mshriver Oct 2, 2019

sbulage Oct 3, 2019

sbulage Oct 16, 2019

sbulage Oct 16, 2019

sshveta Oct 1, 2019

sbulage Oct 2, 2019

mshriver Oct 2, 2019

sbulage Oct 3, 2019 •

edited

Loading

sbulage Oct 13, 2019

mshriver left a comment

dajoRH commented Oct 16, 2019

[1LP][RFR] Embedded Ansible service to check "Cloud Credentials" used in the service. #9414

[1LP][RFR] Embedded Ansible service to check "Cloud Credentials" used in the service. #9414

Conversation

sbulage commented Sep 26, 2019

Purpose or Intent

PRT Run

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sbulage Oct 3, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mshriver left a comment

Choose a reason for hiding this comment

dajoRH commented Oct 16, 2019

sbulage Oct 3, 2019 •

edited

Loading