This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
[1LP][WIP] Adding is_configured property #9478
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnadeem92
changed the title
mnadeem92
changed the title
john-dupuy
reviewed
Oct 14, 2019
cfme/utils/appliance/__init__.py
Outdated
| @property | ||
| def is_configured(self): | ||
| """ Check if the appliance is configured or unconfigured.""" | ||
| return self.db.has_database |
There was a problem hiding this comment.
If the DB is configured shouldn't we also check if the DB has_tables
Suggested change
| return self.db.has_database | |
| return self.db.has_database and self.db.has_tables |
digitronik
suggested changes
Oct 14, 2019
cfme/utils/appliance/__init__.py
Outdated
| @@ -1624,7 +1629,8 @@ def restart_evm_rude(self, log_callback=None): | |||
| self.evmserverd.start() | |||
|
|
|||
| @logger_wrap("Rebooting Appliance: {}") | |||
| def reboot(self, wait_for_web_ui=True, log_callback=None): | |||
| def reboot(self, log_callback=None): | |||
There was a problem hiding this comment.
Required:
It will break our automation with unexpected keyword argument.
Please take wait_for_web_ui arg from user only else I would expect all changes in repo in same PR
digitronik
changed the title
mnadeem92
force-pushed
the
Add_is_configured_prop
branch
from
402a56f to
178c1fe
Compare
Modified the reboot method Signed-off-by: mnadeem92 <[email protected]>
mnadeem92
force-pushed
the
Add_is_configured_prop
branch
from
178c1fe to
7d3df87
Compare
mnadeem92
changed the title
digitronik
changed the title
izapolsk
reviewed
Oct 16, 2019
| @property | ||
| def is_configured(self): | ||
| """ Check if the appliance is configured or unconfigured.""" | ||
| return self.db.has_database and self.db.has_tables |
There was a problem hiding this comment.
I'd look for better way to check whether appliance configured or not. existence of database and tables doesn't guarantee that appliance is configured.
izapolsk
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.