Skip to content

Commit

Permalink
Use core minimum but allow 7.0/7.1/7.2 since core sets upper limit
Browse files Browse the repository at this point in the history
Drop end of life rubies and rails and add new versions

Ensure we're testing and supporting community supported
versions.

Drop:
* rails 6.0
* rails 6.1

Add:
* ruby 3.2
* ruby 3.3
* rails 7.1
* rails 7.2

Note: ruby 3.0 is not difficult to keep maintaining for now but it's on the chopping block.
  • Loading branch information
jrafanie committed Sep 25, 2024
1 parent 5d460fa commit 3a2ff38
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 8 deletions.
9 changes: 7 additions & 2 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,15 @@ jobs:
ruby-version:
- '3.0'
- '3.1'
- '3.2'
- '3.3'
rails-version:
- '6.0'
- '6.1'
- '7.0'
- '7.1'
- '7.2'
exclude:
- ruby-version: '3.0'
rails-version: '7.2'
env:
TEST_RAILS_VERSION: ${{ matrix.rails-version }}
CC_TEST_REPORTER_ID: ${{ secrets.CC_TEST_REPORTER_ID }}
Expand Down
10 changes: 5 additions & 5 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,12 @@ eval_gemfile(dev_gemfile) if File.exist?(dev_gemfile)

minimum_version =
case ENV['TEST_RAILS_VERSION']
when "6.0"
"~>6.0.4"
when "7.0"
"~>7.0.8"
when "7.2"
"~>7.2.1"
when "7.1"
"~>7.1.4"
else
"~>6.1.4"
"~>7.0.8"
end

gem "activesupport", minimum_version
4 changes: 3 additions & 1 deletion manageiq-api-client.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,9 @@ Gem::Specification.new do |spec|
spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
spec.require_paths = ["lib"]

spec.add_dependency "activesupport", ">= 6.0", "<7.1"
spec.required_ruby_version = '>= 3.0'

spec.add_dependency "activesupport", ">= 7.0", "<8.0"
spec.add_dependency "faraday", ">= 1.0", "< 3.0"
spec.add_dependency "faraday-follow_redirects"
spec.add_dependency "json", "~> 2.3"
Expand Down

0 comments on commit 3a2ff38

Please sign in to comment.