Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OSV DDF form pivot value #277

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Conversation

agrare
Copy link
Member

@agrare agrare commented Jan 2, 2025

Fix an issue when editing an Openshift ContainerManager where the Virtualization Type shows as Disabled even though there is an InfraManager already created.

Here is what the ContainerManager Endpoint roles look like:

>> openshift.endpoints.pluck(:role)
=> ["default", "prometheus", "kubevirt"]

So it was looking for an "openshift" role and there wasn't one.

Before:
image

After:
image

Fix an issue when editing an Openshift ContainerManager where the
Virtualization Type shows as Disabled even though there is an
InfraManager already created.
@agrare agrare added the bug label Jan 2, 2025
@agrare agrare requested review from cben and Fryguy as code owners January 2, 2025 17:59
@agrare
Copy link
Member Author

agrare commented Jan 2, 2025

#264 was backported to radjabov so marking this radjabov/yes?

@Fryguy Fryguy merged commit d6c23bb into ManageIQ:master Jan 2, 2025
4 checks passed
@agrare agrare deleted the fix_osv_ddf_pivot branch January 2, 2025 18:26
@Fryguy
Copy link
Member

Fryguy commented Jan 7, 2025

Backported to radjabov in commit 2ab2909.

commit 2ab290926d46427fb6851beb38f2716124cee6b4
Author: Jason Frey <[email protected]>
Date:   Thu Jan 2 13:26:00 2025 -0500

    Merge pull request #277 from agrare/fix_osv_ddf_pivot
    
    Fix OSV DDF form pivot value
    
    (cherry picked from commit d6c23bbbd2563e0363ab6a62b249db990535d3f1)

Fryguy added a commit that referenced this pull request Jan 7, 2025
Fix OSV DDF form pivot value

(cherry picked from commit d6c23bb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants