Fix table pagination setting #9324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fryguy
reviewed
Jan 13, 2025
Fryguy
reviewed
Jan 13, 2025
GilbertCherrie
force-pushed
the
fix_table_pagination_setting
branch
from
4121032 to
4a5b3d4
Compare
Fryguy
reviewed
Jan 14, 2025
| @@ -273,7 +273,7 @@ const setPaging = (settings, start, perPage) => ({ | |||
| const computePagination = (settings) => ({ | |||
| page: settings.current, | |||
| perPage: settings.perpage, | |||
| perPageOptions: [10, 20, 50, 100, 200, 500, 1000], | |||
| perPageOptions: [5, 10, 20, 50, 100, 200, 500, 1000], | |||
There was a problem hiding this comment.
As discussed, this was added to match the Setting side, where 5 is already a choice.
Fryguy
approved these changes
Jan 14, 2025
|
Note, the ruby changes were removed from this pr as we decided the report and report detail page will use the reports items per page value. If we want the report list to use the list value then as a follow up pr we would need to change the tables dbname value. |
|
Backported to |
Fryguy
added a commit
that referenced
this pull request
Jan 16, 2025
…ting Fix table pagination setting (cherry picked from commit f94b162)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issues with table pagination settings.
Before:
The default items per page on the settings page was not actually being applied on the tables in the UI.
As seen here the table defaults to 20 items per page even though in the settings it was set to 10.
Also, 5 items per page is not an option here even though it is on the settings page.
After:
