Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Merge pull request #22901 from jrafanie/drop_default_value_for" #22922

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

jrafanie
Copy link
Member

This reverts commit c773b2b, reversing changes made to bb72015.

Reverting #22901.

This was causing errors in tests where these attribute defaults were triggering "changed" on the attribute, such as in https://github.com/ManageIQ/manageiq-providers-ansible_tower/blob/d5be6cc09a1b2804c1c510c990d5f7061cf2240f/app/models/manageiq/providers/ansible_tower/automation_manager.rb#L28

…value_for"

This reverts commit c773b2b, reversing
changes made to bb72015.
@miq-bot
Copy link
Member

miq-bot commented Feb 29, 2024

Checked commit jrafanie@6a3ef60 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
51 files checked, 7 offenses detected

app/models/blacklisted_event.rb

app/models/notification.rb

app/models/user.rb

spec/lib/extensions/ar_yaml_spec.rb

@agrare agrare merged commit 340776c into ManageIQ:master Feb 29, 2024
8 checks passed
@jrafanie jrafanie deleted the revert_22901 branch February 29, 2024 18:48
@Fryguy
Copy link
Member

Fryguy commented Mar 1, 2024

Backported to radjabov in commit 9acc4b2.

commit 9acc4b2b5ed80f256b678a66eb6d7f0d6ab4913e
Author: Adam Grare <[email protected]>
Date:   Thu Feb 29 13:20:03 2024 -0500

    Merge pull request #22922 from jrafanie/revert_22901
    
    Revert "Merge pull request #22901 from jrafanie/drop_default_value_for"
    
    (cherry picked from commit 340776c59b8ae6199439e2190487e3f3703f8404)

Fryguy pushed a commit that referenced this pull request Mar 1, 2024
Revert "Merge pull request #22901 from jrafanie/drop_default_value_for"

(cherry picked from commit 340776c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants