Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add production.rake helpers for IbmCloud #690

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

Fryguy
Copy link
Member

@Fryguy Fryguy commented Jun 5, 2024

@bdunne Please review.

@miq-bot
Copy link
Member

miq-bot commented Jun 5, 2024

Some comments on commit Fryguy@0caeab7

lib/tasks/production.rake

  • ⚠️ - 99 - Detected puts. Remove all debugging statements.

@miq-bot
Copy link
Member

miq-bot commented Jun 5, 2024

Checked commit Fryguy@0caeab7 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
1 file checked, 1 offense detected

lib/tasks/production.rake

  • ❗ - Line 59, Col 5 - Style/FetchEnvVar - Use ENV.fetch("IBMCLOUD_BOT_API_KEY") or ENV.fetch("IBMCLOUD_BOT_API_KEY", nil) instead of ENV["IBMCLOUD_BOT_API_KEY"].

@bdunne bdunne merged commit 07d3ef4 into ManageIQ:master Jun 10, 2024
3 checks passed
@Fryguy Fryguy deleted the production_helper_ibmcloud branch June 10, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants