-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitHub Action to build and deploy #693
Conversation
@bdunne This is ready to go. I've tested most of the functionality on the setup side for the ibmcloud cli/kubectl via GHA on my fork. The only thing I didn't test was the docker build/push stuff from within GHA. That docker build/push code always worked locally, and the Kube deployment change code also always worked locally (though I did refactor both in this PR). |
- name: Set up kubectl | ||
uses: azure/setup-kubectl@v4 | ||
- name: Set up ibmcloud CLI | ||
uses: IBM/actions-ibmcloud-cli@4fb9b6c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: This is in progress - I'm working to revamp this action - Eventually when I cut a release I'll switch this to @v1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bdunne I released v1, so I've updated this accordingly
lib/tasks/production.rake
Outdated
exit 1 unless system("docker build . --no-cache --build-arg REF=#{version} -t #{image}") | ||
puts | ||
puts "Pushing docker image..." | ||
exit 1 unless system("docker login") && system("docker push #{image}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exit 1 unless system("docker login") && system("docker push #{image}") | |
exit 1 unless system("docker login docker.io") && system("docker push #{image}") |
@bdunne There's some package updates I'm going to merge after this is done, and then use that to test the deployment works. |
Some comments on commit Fryguy@bc46904 lib/tasks/production.rake
|
Checked commit Fryguy@bc46904 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint **
lib/tasks/production.rake
|
No description provided.