Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Action to build and deploy #693

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Conversation

Fryguy
Copy link
Member

@Fryguy Fryguy commented Jun 12, 2024

No description provided.

@miq-bot miq-bot added the wip label Jun 12, 2024
@Fryguy Fryguy changed the title [WIP] Add GitHub Action to build and deploy Add GitHub Action to build and deploy Jun 13, 2024
@miq-bot miq-bot removed the wip label Jun 13, 2024
@Fryguy
Copy link
Member Author

Fryguy commented Jun 13, 2024

@bdunne This is ready to go. I've tested most of the functionality on the setup side for the ibmcloud cli/kubectl via GHA on my fork. The only thing I didn't test was the docker build/push stuff from within GHA. That docker build/push code always worked locally, and the Kube deployment change code also always worked locally (though I did refactor both in this PR).

- name: Set up kubectl
uses: azure/setup-kubectl@v4
- name: Set up ibmcloud CLI
uses: IBM/actions-ibmcloud-cli@4fb9b6c
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: This is in progress - I'm working to revamp this action - Eventually when I cut a release I'll switch this to @v1

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bdunne I released v1, so I've updated this accordingly

exit 1 unless system("docker build . --no-cache --build-arg REF=#{version} -t #{image}")
puts
puts "Pushing docker image..."
exit 1 unless system("docker login") && system("docker push #{image}")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
exit 1 unless system("docker login") && system("docker push #{image}")
exit 1 unless system("docker login docker.io") && system("docker push #{image}")

@Fryguy
Copy link
Member Author

Fryguy commented Jun 17, 2024

@bdunne There's some package updates I'm going to merge after this is done, and then use that to test the deployment works.

@miq-bot
Copy link
Member

miq-bot commented Jun 17, 2024

Some comments on commit Fryguy@bc46904

lib/tasks/production.rake

  • ⚠️ - 146 - Detected puts. Remove all debugging statements.
  • ⚠️ - 158 - Detected puts. Remove all debugging statements.
  • ⚠️ - 160 - Detected puts. Remove all debugging statements.
  • ⚠️ - 164 - Detected puts. Remove all debugging statements.
  • ⚠️ - 166 - Detected puts. Remove all debugging statements.
  • ⚠️ - 167 - Detected puts. Remove all debugging statements.
  • ⚠️ - 171 - Detected puts. Remove all debugging statements.
  • ⚠️ - 174 - Detected puts. Remove all debugging statements.
  • ⚠️ - 185 - Detected puts. Remove all debugging statements.
  • ⚠️ - 187 - Detected puts. Remove all debugging statements.
  • ⚠️ - 188 - Detected puts. Remove all debugging statements.
  • ⚠️ - 190 - Detected puts. Remove all debugging statements.
  • ⚠️ - 198 - Detected puts. Remove all debugging statements.
  • ⚠️ - 200 - Detected puts. Remove all debugging statements.
  • ⚠️ - 203 - Detected puts. Remove all debugging statements.
  • ⚠️ - 204 - Detected puts. Remove all debugging statements.

@miq-bot
Copy link
Member

miq-bot commented Jun 17, 2024

Checked commit Fryguy@bc46904 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
2 files checked, 5 offenses detected

**

  • 💣 💥 🔥 🚒 - Linter/Yaml - missing config files

lib/tasks/production.rake

@bdunne bdunne merged commit 4f0f204 into ManageIQ:master Jun 17, 2024
3 checks passed
@Fryguy Fryguy deleted the deploy_gha branch June 17, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants