Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Wayland pynput v1.7.7 workaround #106

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Conversation

S0AndS0
Copy link
Contributor

@S0AndS0 S0AndS0 commented Feb 4, 2025

XWayland/Wayland does not reliably allow for capture of single key strokes via keyboard event listener(s), but playing about showed key-combos are mostly caught quickly!

Also it seems on Arch Linux (I use Arch BTW™) the key object sent through the keyboard.listener has a different shape, or perhaps the inconsistencies in capture behaviors got me jumping to wrong-thinking.

Either way, these proposed changes should preserve previously programmed key.char detection, while also allowing those stuck with Wayland to enjoy this tool.

XWayland/Wayland does not reliably allow for capture of single key
strokes via keyboard event listener(s), but playing about showed
key-combos are _mostly_ caught quickly!

Also it seems on Arch Linux (I use Arch BTW™) the `key` object sent
through the `keyboard.listener` has a different _shape_, or perhaps the
inconsistencies in capture behaviors got me jumping to wrong-thinking.

Either way, these proposed changes _should_ preserve previously
programmed `key.char` detection, while also allowing those stuck with
Wayland to enjoy this tool.
@S0AndS0 S0AndS0 requested a review from osolmaz as a code owner February 4, 2025 03:26
@osolmaz osolmaz merged commit 05f4fa6 into ManimCommunity:main Feb 5, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants