Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

substitute setup.py with pyproject.toml #58

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

substitute setup.py with pyproject.toml #58

wants to merge 16 commits into from

Conversation

mschwoer
Copy link
Contributor

@mschwoer mschwoer commented Jan 14, 2025 •
edited
Loading

remove setup.py-based installing (needs to be tested still)

Misc:

  • substituted shell: bash -l {0} -> shell: bash -le {0} for easier debugging
  • added requirements handling like in alphadia (two mirrored files + tests)

Note: the versions bumped for gui were implicitly used already in the previous release:

image
(https://github.com/MannLabs/directlfq/actions/runs/11499226277/job/32006749669#logs)
I susspect there's a bug in the old setup.py which strips off versions from all extra packages

@mschwoer mschwoer requested a review from ammarcsj January 14, 2025 14:17
@mschwoer mschwoer marked this pull request as draft January 14, 2025 14:29
Base automatically changed from add_bump_version_workflow to master January 14, 2025 14:51
mschwoer
mschwoer commented Jan 14, 2025
View reviewed changes
tests/pytest/test_requirements.py
@@ -0,0 +1,131 @@
"""Test that the strict and loose requirements files are aligned."""
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code copied from alphaDIA

@mschwoer mschwoer marked this pull request as ready for review January 14, 2025 18:06
ammarcsj
ammarcsj reviewed Jan 15, 2025
View reviewed changes
Copy link
Member

@ammarcsj ammarcsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Installers and software execution worked correctly also for me

release/windows/build_installer_windows.ps1
# Make sure you include the required extra packages and always use the stable or very-stable options!
pip install "dist/directlfq-0.3.1-dev0-py3-none-any.whl[stable, gui]"
python -m build
# Make sure you include the required extra packages and always use the stable options!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this comment still apply?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ammarcsj ammarcsj ammarcsj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mschwoer @ammarcsj