Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make map move when setters used for lat/lon/zoom #796

Closed
wants to merge 5 commits into from

Conversation

AliyanH
Copy link
Member

@AliyanH AliyanH commented Mar 13, 2023

  • Pan/zoom the map when lat/lon/zoom are set.
  • Add tests
  • update documentation
  • Update Spec

resolves #588.

@prushforth
Copy link
Member

This looks good. Let's wait ${some_time} to see if we get an answer about whether we should be reflecting lat,lon,zoom to the content attributes. We will have to update the spec to codify the behaviour, one way or another.

@AliyanH
Copy link
Member Author

AliyanH commented Mar 15, 2023

This looks good. Let's wait ${some_time} to see if we get an answer about whether we should be reflecting lat,lon,zoom to the content attributes. We will have to update the spec to codify the behaviour, one way or another.

Yup, sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setters for zoom, lat, lon should change / move the map location
2 participants