-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose the MapsIndoors Instance so it can be used from the outside #366
Conversation
packages/map-template/src/components/MapTemplate/MapTemplate.jsx
Outdated
Show resolved
Hide resolved
Ready for re-review @ammapspeople |
Oops, missed a check 👀 Pushing the fix now @ammapspeople |
How do I get the instance when using the built React component? 🤔 |
@ammapspeople updated the implementation to expose the MapsIndoors Instance on the window instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should consider how we could document it in the code, and not just on the docs site.
Hmm, I could add a section to the README file, do you think that would be sufficient? @ammapspeople |
@andreeaceachir142 That might work! |
Updated README files @ammapspeople |
Co-authored-by: Anders Mogensen <am@mapspeople.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
@ammapspeople The docs on GitBook has been updated with the new example for |
What
How
Map.jsx
component to be using theuseImperativeHandle
mapsIndoorsInstance
ref
to assign themapsIndoorsInstance
to the window so it can be accessible from the outside