Disable go button when directions are not populated #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s started, set it to true when data is populated, return it
| * and have geometry, call the MapsIndoors SDK to get information about the route. | ||
| */ | ||
| const useDirectionsInfo = (originLocation, destinationLocation, directionsService, travelMode, accessibilityOn) => { | ||
| const [totalDistance, setTotalDistance] = useState() | ||
| const [totalTime, setTotalTime] = useState(); | ||
| const [hasFoundRoute, setHasFoundRoute] = useRecoilState(hasFoundRouteState); | ||
| const [, setDirectionsResponse] = useRecoilState(directionsResponseState); | ||
| const [isDirectionReady, setIsDirectionReady] = useState() |
There was a problem hiding this comment.
Suggested change
| const [isDirectionReady, setIsDirectionReady] = useState() | |
| const [areDirectionsReady, setAreDirectionsReady] = useState() |
We usually use the plural form, "directions".
There was a problem hiding this comment.
I still see isDirectionReady in the code.
There was a problem hiding this comment.
Please try now. I might have not pushed changes for some reason @ammapspeople
| @@ -38,6 +40,7 @@ const useDirectionsInfo = (originLocation, destinationLocation, directionsServic | |||
| totalTime, | |||
| directionsResult | |||
| }); | |||
| setAreDirectionReady(true) | |||
There was a problem hiding this comment.
Could we use one of the existing atoms (for example directionsResponse or hasFoundRoute) instead of introducing a new one? 🤔
|
Done ✅ @ammapspeople |
|
Hey @andreeaceachir142 |
|
Approved ✅ Can you please write some test cases in the ticket so I can test out the feature? @matbmapspeople |
matbmapspeople
deleted the
feature/disable_go_button_when_directions_are_not_populated
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Disable 'Go' button if directions are not populated.
How:
Created a simple boolean that is false when we start fetching data.
When data is populated, the boolean is set to true.
Applied specific styling for disabled button.
Working example:
Screen.Recording.2024-06-17.at.12.50.54.mov
PS. Talking to @andreeaceachir142, I removed two input fields for the time data is being fetched.