Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade Mapbox and Web SDK versions #385

Merged
merged 2 commits into from
Aug 6, 2024
Merged

chore: upgrade Mapbox and Web SDK versions #385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f1ce8cd
chore: upgrade mapbox and SDK versions
matbmapspeople Aug 5, 2024
103aed8
add: changelog
matbmapspeople Aug 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
110 changes: 70 additions & 40 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 7 additions & 0 deletions packages/map-template/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,13 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [1.54.3] - 2024-08-06

### Added

- Upgraded to MapsIndoors SDK v4.36.1.
- Upgraded to mapbox-gl v3.5.2.

## [1.54.2] - 2024-07-31

### Fixed
Expand Down
2 changes: 1 addition & 1 deletion packages/map-template/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"eslint": "^8.39.0",
"eslint-config-react-app": "^7.0.1",
"i18next": "^23.7.7",
"mapbox-gl": "^3.3.0",
"mapbox-gl": "^3.5.2",
"prop-types": "^15.8.1",
"qrcode": "^1.5.3",
"react": "^18.2.0",
Expand Down
4 changes: 2 additions & 2 deletions packages/map-template/src/components/MapTemplate/MapTemplate.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,8 +177,8 @@

const miSdkApiTag = document.createElement('script');
miSdkApiTag.setAttribute('type', 'text/javascript');
miSdkApiTag.setAttribute('src', 'https://app.mapsindoors.com/mapsindoors/js/sdk/4.35.0/mapsindoors-4.35.0.js.gz');
miSdkApiTag.setAttribute('integrity', 'sha384-p/2HpbrD2kC/E62E6RgoVk6NgJN6yGD9o1zbTjNzu933wucQZBvIlyTjCbNVbMMP');
miSdkApiTag.setAttribute('src', 'https://app.mapsindoors.com/mapsindoors/js/sdk/4.36.1/mapsindoors-4.36.1.js.gz');
miSdkApiTag.setAttribute('integrity', 'sha384-1q0Vh8TQZcjeSByW22njbeVz4E327cilRcZZs6uAOS5ZihXmonR7Qm02nvg/vTIR');
miSdkApiTag.setAttribute('crossorigin', 'anonymous');
document.body.appendChild(miSdkApiTag);
miSdkApiTag.onload = () => {
Expand All @@ -194,7 +194,7 @@
if (isInactive) {
resetStateAndUI();
}
}, [isInactive]);

Check warning on line 197 in packages/map-template/src/components/MapTemplate/MapTemplate.jsx

View workflow job for this annotation

GitHub Actions / Release Map Template to npm 

React Hook useEffect has a missing dependency: 'resetStateAndUI'. Either include it or remove the dependency array

/**
* Wait for the MapsIndoors JS SDK to be initialized, then set the mapsindoorsSDKAvailable state to true.
Expand Down Expand Up @@ -249,7 +249,7 @@

setCurrentLanguage(languageToUse);
}
}, [language, mapsindoorsSDKAvailable]);

Check warning on line 252 in packages/map-template/src/components/MapTemplate/MapTemplate.jsx

View workflow job for this annotation

GitHub Actions / Release Map Template to npm 

React Hook useEffect has missing dependencies: 'appConfig.venueImages', 'categories.length', 'currentLanguage', 'currentLocation', 'setCurrentLanguage', 'setCurrentLocation', 'setVenuesInSolution', 'updateCategories', and 'venuesInSolution.length'. Either include them or remove the dependency array

/**
* React on changes in the MapsIndoors API key by fetching the required data.
Expand Down Expand Up @@ -285,7 +285,7 @@
});
setMapReady(false);
}
}, [apiKey, mapsindoorsSDKAvailable]);

Check warning on line 288 in packages/map-template/src/components/MapTemplate/MapTemplate.jsx

View workflow job for this annotation

GitHub Actions / Release Map Template to npm 

React Hook useEffect has missing dependencies: 'setApiKey', 'setAppConfig', 'setMapReady', 'setSolution', and 'setVenuesInSolution'. Either include them or remove the dependency array

/*
* Set map provider access token / API key based on props and app config.
Expand All @@ -295,7 +295,7 @@
setMapboxAccessToken(mapboxAccessToken || appConfig.appSettings?.mapboxAccessToken);
setGmApiKey(gmApiKey || appConfig.appSettings?.gmKey);
}
}, [gmApiKey, mapboxAccessToken, mapsindoorsSDKAvailable, appConfig]);

Check warning on line 298 in packages/map-template/src/components/MapTemplate/MapTemplate.jsx

View workflow job for this annotation

GitHub Actions / Release Map Template to npm 

React Hook useEffect has missing dependencies: 'setGmApiKey' and 'setMapboxAccessToken'. Either include them or remove the dependency array

/*
* React on changes in the app user roles prop.
Expand Down Expand Up @@ -323,7 +323,7 @@
setFilteredLocationsByExternalID([]);
}
}
}, [externalIDs, mapsindoorsSDKAvailable]);

Check warning on line 326 in packages/map-template/src/components/MapTemplate/MapTemplate.jsx

View workflow job for this annotation

GitHub Actions / Release Map Template to npm 

React Hook useEffect has a missing dependency: 'setFilteredLocationsByExternalID'. Either include it or remove the dependency array

/*
* React on changes to the locationId prop.
Expand All @@ -341,7 +341,7 @@
});
}
}
}, [locationId, mapsindoorsSDKAvailable, resetCount]);

Check warning on line 344 in packages/map-template/src/components/MapTemplate/MapTemplate.jsx

View workflow job for this annotation

GitHub Actions / Release Map Template to npm 

React Hook useEffect has missing dependencies: 'setCurrentLocation', 'setCurrentVenueName', and 'setLocationId'. Either include them or remove the dependency array

/*
* React to changes in the gmMapId prop.
Expand All @@ -350,7 +350,7 @@
if (mapsindoorsSDKAvailable) {
setGmMapId(gmMapId);
}
}, [gmMapId, mapsindoorsSDKAvailable]);

Check warning on line 353 in packages/map-template/src/components/MapTemplate/MapTemplate.jsx

View workflow job for this annotation

GitHub Actions / Release Map Template to npm 

React Hook useEffect has a missing dependency: 'setGmMapId'. Either include it or remove the dependency array

/*
* Add Location to history payload to make it possible to re-enter location details with that Location.
Expand All @@ -371,21 +371,21 @@
// Apply the previously filtered locations to the map when navigating outside the directions.
setFilteredLocations(initialFilteredLocations);
}
}, [currentAppView]);

Check warning on line 374 in packages/map-template/src/components/MapTemplate/MapTemplate.jsx

View workflow job for this annotation

GitHub Actions / Release Map Template to npm 

React Hook useEffect has missing dependencies: 'appStates.DIRECTIONS', 'appStates.LOCATION_DETAILS', 'currentAppViewPayload', 'currentLocation', 'filteredLocations', 'initialFilteredLocations', 'setCurrentLocation', and 'setFilteredLocations'. Either include them or remove the dependency array

/*
* React on changes in the venue prop.
*/
useEffect(() => {
setCurrentVenueName(venue);
}, [venue]);

Check warning on line 381 in packages/map-template/src/components/MapTemplate/MapTemplate.jsx

View workflow job for this annotation

GitHub Actions / Release Map Template to npm 

React Hook useEffect has a missing dependency: 'setCurrentVenueName'. Either include it or remove the dependency array

/*
* React on changes in the tile style prop.
*/
useEffect(() => {
setTileStyle(tileStyle);
}, [tileStyle]);

Check warning on line 388 in packages/map-template/src/components/MapTemplate/MapTemplate.jsx

View workflow job for this annotation

GitHub Actions / Release Map Template to npm 

React Hook useEffect has a missing dependency: 'setTileStyle'. Either include it or remove the dependency array

/*
* React on changes in the primary color prop.
Expand Down
Loading