Fix scroll buttons disabled/enabled states in the Kiosk mode #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ammapspeople
reviewed
Aug 6, 2024
packages/components/src/components/scroll-buttons/scroll-buttons.tsx
Outdated
Show resolved
Hide resolved
|
There's still some naming referring to locations and categories in the scroll buttons web component. |
How about now @ammapspeople |
packages/components/src/components/scroll-buttons/scroll-buttons.tsx
Outdated
Show resolved
Hide resolved
packages/components/src/components/scroll-buttons/scroll-buttons.tsx
Outdated
Show resolved
Hide resolved
|
New changes pushed @ammapspeople |
packages/components/src/components/scroll-buttons/scroll-buttons.tsx
Outdated
Show resolved
Hide resolved
packages/components/src/components/scroll-buttons/scroll-buttons.tsx
Outdated
Show resolved
Hide resolved
|
I cleaned up a little bit now and we do not use additional property. We also do not check for length. @ammapspeople |
|
What do you think about it now @ammapspeople ☝️ |
packages/components/src/components/scroll-buttons/scroll-buttons.tsx
Outdated
Show resolved
Hide resolved
Much better 👏 |
ammapspeople
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated
updateScrollButtonsState()function so it gets a proper disabled state when locations' length is lower than 8. Number 8 indicates maximum number of locations that are visible in the element without scroll.Inside
Search.jsx, I called newly created functionnewCategorySelected(). When new category is selected, and all locations to that category are rendered, we need to update disabled/enabled state of scroll buttons.I performed a lot of scouting.