Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add placeholder property to mi-dropdown #390

Merged

Conversation

matbmapspeople
Copy link
Contributor

For PI improvement, I need a different text inside placeholder. To not break current interface, I made this implementation.

@matbmapspeople
Copy link
Contributor Author

Do I need to change anything else to make it available to CMS components after releasing it to PROD? @ammapspeople

@ammapspeople
Copy link
Contributor

Do I need to change anything else to make it available to CMS components after releasing it to PROD? @ammapspeople

You'll need to update the components package in the CMS to the version in which this will be released.

Copy link
Contributor

@ammapspeople ammapspeople left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😁

@matbmapspeople matbmapspeople merged commit 73cefe8 into main Sep 18, 2024
@matbmapspeople matbmapspeople deleted the feature/matb/MICMS-3835_add_placeholder_to_dropdown branch September 18, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants