Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.60.0 #418

Closed
wants to merge 16 commits into from
Closed

Release 1.60.0 #418

wants to merge 16 commits into from

Conversation

Lucaci-Andrei
Copy link
Contributor

  • Added MAX_RESULTS constant to limit the maximum number of search results displayed at once
  • Sort venues by display name

Copy link

sentry-io bot commented Nov 29, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: packages/map-template/src/components/Search/Search.jsx

Function Unhandled Issue
Search Error: Invalid argument to useRecoilState: expected an atom or selector but got undefined ...
Event Count: 1 Affected Users: 3
Search TypeError: Cannot read properties of undefined (reading 'length') ...
Event Count: 1 Affected Users: 1

Did you find this useful? React with a 👍 or 👎

@@ -5,6 +5,11 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [1.60.0] - 2024-12-05
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to update the date to be correct just before merging.

packages/map-template/CHANGELOG.md Outdated Show resolved Hide resolved
packages/map-template/CHANGELOG.md Show resolved Hide resolved
packages/map-template/CHANGELOG.md Outdated Show resolved Hide resolved
- Limit the maximum number of search results to 100 to improve render performance.

### Fixed
- Fixed a bug where the selected venue (in case no venue was set otherwise) was picked alphabetically by Administrative ID rather than the displayed Venue name.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Fixed a bug where the selected venue (in case no venue was set otherwise) was picked alphabetically by Administrative ID rather than the displayed Venue name.
- Fixed a bug where the selected venue (in case no venue was set otherwise) was picked alphabetically by Administrative ID rather than the displayed Venue name.

@Lucaci-Andrei Lucaci-Andrei deleted the release-1.60.0 branch December 10, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants