Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Click on non MapsIndoors data to exit location details #429

Merged
merged 89 commits into from
Jan 8, 2025
Merged

Click on non MapsIndoors data to exit location details #429

merged 89 commits into from
Jan 8, 2025

Conversation

Lucaci-Andrei
Copy link
Contributor

@Lucaci-Andrei Lucaci-Andrei commented Dec 10, 2024 •
edited
Loading

  • Add custom hook with click event listeners that handle Mapbox and Google Maps to close LocationDetails if the clicked area does not have MapsIndoors data

@Lucaci-Andrei Lucaci-Andrei marked this pull request as ready for review December 11, 2024 10:24
Lucaci-Andrei and others added 14 commits December 11, 2024 12:25
@Lucaci-Andrei
add TODOs
2dcedb9
@ammapspeople
refactor: use the SDK method goTo instead of rolling our own.
14e368f
@Lucaci-Andrei
chore: Update CHANGELOG
1256ff2
@Lucaci-Andrei
chore: update CHANGELOG
65f1919
@ammapspeople
chore: upgrade MapsIndoors SDK version to get a bugfix for goTo().
65b31b5
@Lucaci-Andrei
Merge pull request #430 from MapsPeople/feature/update-accessibility-…
ee14b97 
…toggle-text

Update "Accessibility" toggle text to "Avoid stairs and escalators"
@github-actions
Release @mapsindoors/[email protected]
30c5f33
@ammapspeople
refactor: replace the home-baked functions for setting the map bounds…
063a599 
… with the goTo method in the MapsIndoors JS SDK.
@ammapspeople
fix: avoid the map centering on unexpected places in the world by ens…
0881cbc 
…uring that the setZoom is called only after the map settles.
@ammapspeople
chore: remove note. That is not a requirement after all.
6878c90
@ammapspeople
fix: use https.
edad792
@eNepper
feat: add dropdown alignment property and update rendering logic
c299f46
@eNepper
fix: adjust dropdown item spacing and remove unnecessary margins
50c514b
@ammapspeople
refactor: rename.
99cb310
Lucaci-Andrei and others added 28 commits January 7, 2025 15:02
@Lucaci-Andrei
feat: add mapClickState atom for managing map click state
da49a8f
@Lucaci-Andrei
feat: integrate mapClickState to handle location click events
8cfab58
@Lucaci-Andrei
feat: add click event handling to MapboxMap for feature detection
f32539c
@Lucaci-Andrei
fix: remove cleanup for map click event listener in MapboxMap
83c789c
@Lucaci-Andrei
feat: add wayfinding state management to LocationDetails component
851de30
@Lucaci-Andrei
feat: add click event handling for Google Maps to manage map click state
19ceac8
@Lucaci-Andrei
fix: move click useEffect
294dcfe
@Lucaci-Andrei
add TODOs
17154f0
@Lucaci-Andrei
feat: add custom hook for handling map click events in Mapbox and Goo…
7aa6a48 
…gle Maps
@Lucaci-Andrei
refactor: format document and move map declaration
005bf2f
@Lucaci-Andrei
refactor: remove unused mapClickState atom
9c91b23
@Lucaci-Andrei
refactor: remove unused mapClickState and click event listeners from …
3c406c5 
…GoogleMapsMap and MapboxMap components
@Lucaci-Andrei
refactor: replace mapClickState with useMapClick hook in LocationDetails
2827b18
@Lucaci-Andrei
refactor: remove unused useRecoilState import from GoogleMapsMap comp…
9f98b2c 
…onent
@Lucaci-Andrei
refactor: import and use mapTypes constant
3975d44
@Lucaci-Andrei
refactor: enhance click event handling in useMapClick hook
906bd1a
@Lucaci-Andrei
refactor: add JSDoc for useMapClick hook
584d119
@Lucaci-Andrei
refactor: update condition to exit location details when wayfinding i…
a8a345b 
…s not active
@Lucaci-Andrei
refactor: rename useMapClick hook to useOutsideMapsIndoorsDataClick a…
7930e5a 
…nd update import in LocationDetails component
@Lucaci-Andrei
refactor: add isOpen prop to LocationDetails and Sidebar components f…
8915416 
…or better state management
@Lucaci-Andrei
refactor: pass isOpen prop to useOutsideMapsIndoorsDataClick hook for…
fac427a 
… improved click handling outside of MapsIndoors Data
@Lucaci-Andrei @ammapspeople
refactor: Fix JSDoc description
ffe3a97 
Co-authored-by: Anders Mogensen <[email protected]>
@Lucaci-Andrei @ammapspeople
Update packages/react-components/src/components/MIMap/MapboxMap/Mapbo…
463ef02 
…xMap.jsx

Co-authored-by: Anders Mogensen <[email protected]>
@Lucaci-Andrei @ammapspeople
Update packages/map-template/src/hooks/useOutsideMapsIndoorsDataClick.js
290cd5f 
Co-authored-by: Anders Mogensen <[email protected]>
@Lucaci-Andrei
refactor: separated Mapbox and Google Maps specific logic into separa…
6aa1ddc 
…ted functions
@Lucaci-Andrei
refactor: remove console.log statements from useOutsideMapsIndoorsDat…
e108fa2 
…aClick hook for cleaner code
@Lucaci-Andrei
Merge branch 'feature/exit-location-details-on-click' of github.com:M…
a83bfa2 
…apsPeople/web-ui into feature/exit-location-details-on-click
@Lucaci-Andrei
chore: update CHANGELOG
e3bed01
@Lucaci-Andrei Lucaci-Andrei merged commit 118dbf3 into main Jan 8, 2025
@Lucaci-Andrei Lucaci-Andrei deleted the feature/exit-location-details-on-click branch January 8, 2025 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ammapspeople ammapspeople ammapspeople approved these changes

Assignees
No one assigned
Labels
minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lucaci-Andrei @ammapspeople @eNepper