Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdown enhancements #432

Merged
merged 4 commits into from
Dec 16, 2024
Merged

Dropdown enhancements #432

merged 4 commits into from
Dec 16, 2024

Conversation

eNepper
Copy link
Contributor

@eNepper eNepper commented Dec 13, 2024

I made a few minor changes to the dropdown component.

  • Added an alignment attribute to set the dropdown on which side of the button will align. Possible values are left and right, and the default is left.
  • If set the label will be shown as the value in the dropdown button. (Not only for multi-select)

@eNepper eNepper requested a review from ammapspeople December 13, 2024 14:12
@eNepper eNepper added the minor label Dec 16, 2024
ammapspeople
ammapspeople approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@ammapspeople ammapspeople left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@eNepper eNepper merged commit 1e31270 into main Dec 16, 2024
@eNepper eNepper deleted the feature/en/dropdown-update branch December 16, 2024 09:10
@eNepper eNepper self-assigned this Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ammapspeople ammapspeople ammapspeople approved these changes

Assignees

@eNepper eNepper

Labels
minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eNepper @ammapspeople