Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Click on non MapsIndoors data to exit categories if active. #435

Merged
merged 6 commits into from
Jan 15, 2025
Merged

Click on non MapsIndoors data to exit categories if active. #435

merged 6 commits into from
Jan 15, 2025
+39 −1

Conversation

Lucaci-Andrei
Copy link
Contributor

What

  • Fix issue of clicking outside of MapsIndoors data to close the Categories tab

How

  • Implement the usage of the custom hook useOutsideMapsIndoorsDataClick in Categories
  • Add a prop to Categories that determines if it is open or not

Lucaci-Andrei and others added 2 commits January 9, 2025 14:00
@Lucaci-Andrei @andreeaceachir142
refactor: Fix JSDoc description
2993026 
Co-authored-by: Andreea Ceachir <[email protected]>
@Lucaci-Andrei
bugfix: add comments to cleanup useEffect in the Categories component…
ffb77e7 
… and call clear function if searchField has any text.
@Lucaci-Andrei Lucaci-Andrei merged commit 6db6207 into main Jan 15, 2025
@Lucaci-Andrei Lucaci-Andrei deleted the bugfix/exit-location-details-on-click-from-categories branch January 15, 2025 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreeaceachir142 andreeaceachir142 andreeaceachir142 approved these changes

Assignees
No one assigned
Labels
patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lucaci-Andrei @andreeaceachir142