-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Map template: fit bounds when selecting category #438
Merged
ammapspeople
merged 9 commits into
main
from
feature/map-template-fit-bounds-when-selecting-category
Jan 16, 2025
Merged
Map template: fit bounds when selecting category #438
ammapspeople
merged 9 commits into
main
from
feature/map-template-fit-bounds-when-selecting-category
Jan 16, 2025
+55
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ray of Locations.
… timing issue when it is used early.
ammapspeople
requested review from
matbmapspeople,
andreeaceachir142 and
Lucaci-Andrei
January 9, 2025 12:06
Co-authored-by: Anders Mogensen <am@mapspeople.com>
LGTM ✅ |
👍 |
andreeaceachir142
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🆗 🆗 🆗
ammapspeople
deleted the
feature/map-template-fit-bounds-when-selecting-category
branch
January 16, 2025 11:48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Make the map fit to matching Locations when the user clicks/taps on a Category.
How
fitMapBoundsToLocations
. When called, it will build an array of GeoJSON features to be passed to the MapsIndoors JS SDK methodgoTo
which will ensure that the map is fitted to encompass those Locations.onResults
function in the the Search component was extended with an optionalfitMapBounds
parameter, which when set to true will call the newfitMapBoundsToLocations
function.fitMapBounds
parameter is set to true only when calling from thegetFilteredLocations
function, which is only run when the user clicks on a Category.isDesktop
would be falsely false (😁) at that time.