-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix zooming when Map Bounds are not fitted #442
Fix zooming when Map Bounds are not fitted #442
Conversation
Let me know if there are any code suggestions from you @Lucaci-Andrei @ammapspeople |
Did you manage to find some time checking this possible solution 😄? |
Looks good to me 👍 |
Did you also manage to test it @Lucaci-Andrei ? |
Yes, I tested it on the solution where the issue occured. The bug did not re-appear in my tests |
Do you have any opinions about this approach @ammapspeople? |
@matbmapspeople My opinion is that this needs to be tested thoroughly. |
I found out that
mapPositionKnown
property has two values during its' lifetime: false - when the location is not known and GeoJSON object - when location is known.To fix it I passed
mapPositionKnown
as last param togoTo()
function and I explicitly check ifmapPositionKnown
is not false. Then I perform zooming.Working solution:
Uploading Screen Recording 2025-01-14 at 20.33.42.mov…