Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move copy code resolution to lexer #412

Closed
wants to merge 36 commits into from
Closed

Move copy code resolution to lexer #412

wants to merge 36 commits into from

Conversation

MarkusAmshove
Copy link
Owner

@MarkusAmshove MarkusAmshove commented Oct 30, 2023 •
edited
Loading

closes #411

Make sure the following stuff still works:

  • go to reference on a copy code name
  • find references within a copy code
  • define data parser correctly routes diagnostic positions
  • natlint correctly shows additional positions
  • all calls to lexer use the new lexer where applicable

@MarkusAmshove MarkusAmshove added the natparse🔎 Parser and project structure label Oct 30, 2023
@MarkusAmshove
Draft CopyCodeResolver
5281ff6
@MarkusAmshove
Add tool to dump resolved tokens
22917d2
@MarkusAmshove
Rename CopyCodeResolver
3b99633
@MarkusAmshove
Completely do the resolution within IncludeResolvingLexer
261cc7a
@MarkusAmshove
Migrate some tests
2581dcc
@MarkusAmshove
Migrate array access test
aec0bfb
@MarkusAmshove
Create qualified names with tokens that can be identifier
4794c8d
@MarkusAmshove
Handle missing parameters
ef82a00
@MarkusAmshove
Add tests for nested copycodes
c0466ea
@MarkusAmshove
Disable test that doesn't compile but keep it for documentation
97c67a3
@MarkusAmshove
Resolve nested include parameter before resolving nested include
3e77afc 
This makes sure that the INCLUDE can be correctly resolved if the nested INCLUDE
has a copy code parameter as parameter itself, e.g.:

INCLUDE NESTED &1&
@MarkusAmshove
Add another edge case
8a367b6
@MarkusAmshove
Make sure to roll back parameter's TokenList
030fe86
@MarkusAmshove
Raise diagnostics for unresolved modules and wrong module types
36fdb8a
@MarkusAmshove
Combine some more tokens
fd13ee4
@MarkusAmshove
Raise diagnostic for cyclomatic includes
2129c39
@MarkusAmshove
Test source replacement instead of token replacement
d1043fc
@MarkusAmshove
Roll back changes to Lexer
566ac58
@MarkusAmshove
Allow COPYCODE_PARAMETER to be treated as identifier
eaf13fa 
This is to silence errors when programming within a NSC file
@MarkusAmshove
Merge remote-tracking branch 'origin/main' into natparse/move-copycod…
45b967f 
…e-resolution-to-lexer
@MarkusAmshove
Add multiple unprovided parameter location to same diagnostic
685b63e
@MarkusAmshove
Recognize copycode locations from diagnostics
cb9ef3a
@MarkusAmshove
Use new Lexer in Language Server
1a80313
@MarkusAmshove
Don't duplicate diagnostics
0fd50ea
@MarkusAmshove
Use new Lexer in most test scenarios
53f7684
@MarkusAmshove
Relocate when creating diagnostic
fa4a103
@MarkusAmshove
Handle copy code parameter with string concat
702b727
@MarkusAmshove
Test diagnostic position of nested includes
905ea01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
natparse🔎 Parser and project structure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move INCLUDE resolution into the Lexer
1 participant
@MarkusAmshove