-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite using new Javadoc API #17
base: master
Are you sure you want to change the base?
Rewrite using new Javadoc API #17
Conversation
Java changed to version 11 Version changed to 2.0.0-SNAPSHOT
[WARNING] Error injecting: org.codehaus.plexus.archiver.jar.JarArchiver |
Upping the version of the asembly plugin appears to resolve that issue |
Also looks like it ignores -d ${project.build.directory} -filename javadoc.xml |
|
@red61wjt thanks for trying this PR. |
Yup, that appears to fix it. Was that an intentional change to move from additionalparam to additionalOptions or was it undocumented feature that additionalparam worked before? |
I think this was a change in javadoc itself. |
When I used cyrillic in comments, these changes generated UTF-16 symbols, for example I resolved it, added dependency org.apache.commons:commons-text, and wrapped "fullBody" with StringEscapeUtils.unescapeeEcmaScript(fullBody), and got the right format, for example Maybe this change is ugly hack, but I didn't find another resolution. |
@russo595 thanks for sharing your solution. I think proper way to output unicode characters would be to create subclass of |
@vojtechhabarta Hi, any chance you would consider repackaging your version of the xmldoclet under your own Maven coordinates and posting to central please? I have a really tough job trying to get our students Javadocs reformatted into Word for their project write-ups. Having JavaDoc -> XML -> XSLT -> Lots would provide a workable solution for us and a lot of others. If not, would you object if I did? |
Salvaged the project from https://github.com/MarkusBernhardt/xml-doclet with PR MarkusBernhardt#17 and sanitized the build script and sources. Supports JavaDoc 11 up to JavaDoc 13. - Gradle Build, drop Maven - Format and Check sources - Publish to GitHub packages
Greetings. <docletArtifact>
<groupId>com.manticore-projects.tools</groupId>
<artifactId>xml-doclet</artifactId>
<version>1.1.3</version>
</docletArtifact> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clicked it by mistake
In Java 13 old doclet API (
com.sun.javadoc
) is removed and only new doclet API (jdk.javadoc.doclet
) should be used.This PR is rewrite using new API. It is a prototype which contains both old and new doclets and can be built using Java 11. To support Java 13 old doclet needs to be removed. New doclet passes all 55 tests and I also tested it (and compared with old doclet) on real project.
I am interested in this doclet because I am using its XML format in https://github.com/vojtechhabarta/typescript-generator. Please let me know if you have any plans with this project so I can decide how to make typescript-generator work on Java 13.
Thanks