-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handle MultipleObjectsReturned for form data #12
Conversation
I'd prefer the data = None
display_key = ...
if display_key is not None:
data = ... |
Could you also add a test case to |
Sure, will add tests later in the evening |
Thanks. If you rebase to the current develop branch the tests for Django 1.8 should pass. I just pushed a fix. |
Sorry wrong branch, I forgot Github updates PR. But this commit might be good thing to pull in upstream https://github.com/chhantyal/django-dynamic-forms/commit/3ffc28c16211b33f4e69c5125d6e2066991896f5 |
Can you please submit 3 independent pull requests for the features.
|
We also need to handle MultipleObjectsReturned as we allow nullable
display_key
in table. So when display_key url param is empty, above exception is raised.We could also do,
Let me know which one you prefer.