Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose CmdFromDir #65

Merged
merged 1 commit into from
Jan 30, 2017
Merged

Conversation

erizocosmico
Copy link
Contributor

Exposes internal functionality of RunFromDir to create a command run from the repo's directory as CmdFromDir.

Exposes internal functionality of RunFromDir to create a command
run from the repo's directory as CmdFromDir.
@AppVeyorBot
Copy link

@dmitshur
Copy link

This slightly reminds me of #42. It may or may not be relevant, but I'll mention it here just in case it's helpful to you. See #42 (comment) especially.

@erizocosmico
Copy link
Contributor Author

erizocosmico commented Jan 29, 2017

Yeah, I guess they're similar. The difference, though, is that with RunFromDir you are already giving the user something to run a custom command, so they might also need access to that command to do something special with it. In #42 what's exposed is a way to get the already defined commands.

For example, in sdboyer/gps#84 it would be impossible doing a fix without access to the *exec.Cmd (using vcs, at least), because you have no control over the command or the process.

@mattfarina
Copy link
Member

I like the style of this more than #42. It's more generalized and in a similar vein to RunFromDir.

@mattfarina mattfarina merged commit abd1ea7 into Masterminds:master Jan 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants