Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to check less often for level-ups #2

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

katepzrp
Copy link
Contributor

@katepzrp katepzrp commented May 1, 2024

As part of an effort to reduce server load, I'd like to propose this change to make it an option to run the skill limiter less often.

@MaxWasUnavailable
Copy link
Owner

Have you profiled this and noticed any significant difference in performance? (Preferably with some actual stats)

The original system already only runs (anything remotely impactful) once every 30 ticks.

@katepzrp
Copy link
Contributor Author

katepzrp commented May 1, 2024

Have you profiled this and noticed any significant difference in performance? (Preferably with some actual stats)

The original system already only runs (anything remotely impactful) once every 30 ticks.

Let me get together with our server staff and discuss how we can get you these stats.

@katepzrp
Copy link
Contributor Author

katepzrp commented May 1, 2024

Have you profiled this and noticed any significant difference in performance? (Preferably with some actual stats)
The original system already only runs (anything remotely impactful) once every 30 ticks.

Let me get together with our server staff and discuss how we can get you these stats.

We don't have specific statistics, but we have noticed a drop in performance since we added the mod. It wasn't the only mod added at the time, but it was the only one to loop into the EveryTick event, trivially or no.

If you'd like us to test before updating the mod, would you allow us to repack the updated version into our server code? Lack of permission to do so is what's kept us from seeing whether this is the specific issue (without removing the mod entirely, which we'd like to avoid).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants