Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0nikola1 patch octoprint proxy #89

Merged

Conversation

0nikola1
Copy link
Contributor

Fix for issue mentioned in #87 with s6-overlay-suexec: fatal: can only run as pid 1 based on addons example documentation.

Copy link

@hacstest hacstest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix s6-overlay-suexec: fatal: can only run as pid 1
please verify and merge

@MaxWinterstein
Copy link
Owner

Does this really work for you? With login and all needed stuff?

@0nikola1
Copy link
Contributor Author

0nikola1 commented Dec 5, 2022

It does, I use it for few months now.
I used it on Pi3, Pi4 and Proxmox VM. Not sure if there is better way to solve this but this works for me.

@MaxWinterstein
Copy link
Owner

It does, I use it for few months now. I used it on Pi3, Pi4 and Proxmox VM. Not sure if there is better way to solve this but this works for me.

I am so confused, can't describe.

Are you accessing a OctoPi installation or a plain OctoPrint installation?

@0nikola1
Copy link
Contributor Author

0nikola1 commented Dec 5, 2022

It does, I use it for few months now. I used it on Pi3, Pi4 and Proxmox VM. Not sure if there is better way to solve this but this works for me.

I am so confused, can't describe.

Are you accessing a OctoPi installation or a plain OctoPrint installation?

I am using it to access OctoPi installation and some other local devices sometimes. I have this addon installed on both Pi and VM with HA OS

P.S. I didn't update OctoPi for some time so not sure if on new version login still works

@MaxWinterstein
Copy link
Owner

wow, words can't tell how mad/confused/angry i am.

I am spending half the day on tweaking nginx configs, switching between haproxy and others and now I found it. The root cause of my issues.

I am exposing home assistant through the nginx proxy manager addon. Accessing my HA installation through this has become my normal way to do this, no matter if I am at home or not. (besides some DNS tweaking that my external domain directly points to my HA machine at home).

I route public port XXXX towards the export port XXXX of the addon, whereas it routes to 8123 of localhost. (I guess, somehow it won't show me the config at the moment, just blank?)

If I access HA directly through its well-known port 8123 it works! (At least the /reverse_proxy_test page - new and cool!)

Left, direct access towards HA, right, through nginx proxy manager

image

This is the first time I encounter such strange behavior :(

No idea what is happening here...

P.S. I didn't update OctoPi for some time so not sure if on new version login still works

I guess, they changed a lot of stuff on that regarding the loging.

@MaxWinterstein
Copy link
Owner

Will merge this for now.

Lets continue the discussion about 1.83 and other e.g. here: #115

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants