Update front.html.twig Add border to non federated notifications for admins and moderators #1297
Conversation
Add border to non federated notifications for admins and moderators This allows admins/moderators (when they receive notifications in the future) to quickly see if there has been any activity by local users on their instance
melroy89
added
enhancement
|
I'm not so sure about this change. Not that I'm not in favor to make it clear whether it's federated or non-federated notification. It's more about how to solve this issue. I believe adding a border would only add confusing. Only you now know what this means, but its not clear at all what a border means around a notification at all. If you would try to distinguish between local or federated messages. I believe we should solve it differently. Maybe with an icon + alt text or something, not a "random" border. |
I can add an alt text, that's a great idea. I've been using this for a while now and it works really well for me. The border is subtle but still catches my attention. I think it works better than an icon, I know from experience icons can be missed when skimming lists. These borders are hard to miss |
…r-admins-and-moderators
|
Added tooltip with username. Don't remember who but someone said it would be nice to be able to see which instance something was posted from. 2 birds with one stone. I don't feel this should be iconified. (Ignore the 'comment' it's for testing purposes) |
Title shows entry as local and author
It does, see my comment above |
|
My new approach comes with the advantage of having more control over what the notifications look like, I've resisted the urge to go wild but have added a little envelope to notifications when they are about messages.
let me know what you think. It's just an ✉ emoticon so doesn't need additional image handling (this is also for regular users) |
…r-admins-and-moderators
…r-admins-and-moderators
remove bordering from here
Saves a lot of var checking and gives more potential for future visual improvements in the notifications
…r-admins-and-moderators
|
@TheVillageGuy I bet the failing tests are caused by your changes regarding the css classes. The tests will have css selectors on them that just don't match anymore |
The changes are the same as before though, when they did pass the tests. Just achieved in a different way from the code. Haven't had time to look at the tests yet |
…r-admins-and-moderators
|
Sorry, you didn't made 1.7.4 release. |
Add border to non federated notifications for admins and moderators
This allows admins/moderators (when they receive notifications in the future) to quickly see if there has been any activity by local users on their instance