Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test case for liking a hashtag matched post #1364

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Add test case for liking a hashtag matched post #1364

merged 1 commit into from
Jan 13, 2025

Conversation

BentiGorlich
Copy link
Member

Add test case for:

  • a local user liking a hashtag matched post
  • a remote user liking a hashtag matched post

Discovered in this process:

  • too many likes were announced by the magazine. These like messages are expected to already be sent to the author of the liked post, so we do not need to announce them to them, only to the subscribers of the magazine

@BentiGorlich
Add test case for liking a hashtag matched post
3c8b6ed 
Add test case for:
- a local user liking a hashtag matched post
- a remote user liking a hashtag matched post

Discovered in this process:
- too many likes were announced by the magazine. These like messages are expected to already be sent to the author of the liked post, so we do not need to announce them to them, only to the subscribers of the magazine
@BentiGorlich BentiGorlich added activitypub ActivityPub related issues backend Backend related issues and pull requests testing Unit/Functional/Integration test issues and pull requests labels Jan 13, 2025
@BentiGorlich BentiGorlich self-assigned this Jan 13, 2025
@BentiGorlich BentiGorlich mentioned this pull request Jan 13, 2025
Merged
@melroy89 melroy89 added this to the v1.7.4 milestone Jan 13, 2025
@BentiGorlich BentiGorlich merged commit 9cf5e1a into main Jan 13, 2025
7 checks passed
@BentiGorlich BentiGorlich deleted the new/test-hastag-matching-like branch January 13, 2025 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melroy89 melroy89 melroy89 approved these changes

Assignees

@BentiGorlich BentiGorlich

Labels
activitypub ActivityPub related issues backend Backend related issues and pull requests testing Unit/Functional/Integration test issues and pull requests
Projects
None yet
Milestone
v1.7.4
Development

Successfully merging this pull request may close these issues.
2 participants
@BentiGorlich @melroy89