Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAT-8150 and 8151: Value Set Search - Definition Version #449

Merged
merged 14 commits into from
Jan 31, 2025
Merged

Conversation

ethankaplan
Copy link
Contributor

@ethankaplan ethankaplan commented Jan 23, 2025

MADiE PR

Jira Ticket: MAT-8150 and MAT-8151
(Optional) Related Tickets:

Summary

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included
  • No extemporaneous files are included (i.e Complied files or testing results)
  • This PR is in to the correct branch.
  • All Documentation as needed for this PR is Complete (or noted in a TODO or other Ticket)
  • Any breaking changes or failing automation are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package)
  • All CDN/Web dependancies are hosted internally (i.e MADiE-Root Repo)

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 71.42857% with 4 lines in your changes missing coverage. Please review.

Project coverage is 89.92%. Comparing base (2cc9e5c) to head (033f3ca).
Report is 15 commits behind head on develop.

Files with missing lines Patch % Lines
src/CqlBuilderPanel/ValueSets/Search/Search.tsx 81.81% 1 Missing and 1 partial ⚠️
...nctionsSection/functionBuilder/FunctionBuilder.tsx 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #449      +/-   ##
===========================================
- Coverage    90.06%   89.92%   -0.15%     
===========================================
  Files           75       75              
  Lines         2034     2045      +11     
  Branches       386      393       +7     
===========================================
+ Hits          1832     1839       +7     
- Misses         127      129       +2     
- Partials        75       77       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ethankaplan ethankaplan marked this pull request as ready for review January 23, 2025 19:58
@ethankaplan ethankaplan requested a review from a team as a code owner January 23, 2025 19:59
@ethankaplan ethankaplan changed the title MAT-8150: Value Set Search - Definition Version MAT-8150 or 8151: Value Set Search - Definition Version Jan 23, 2025
@ethankaplan ethankaplan changed the title MAT-8150 or 8151: Value Set Search - Definition Version MAT-8150 and 8151: Value Set Search - Definition Version Jan 31, 2025
mcmcphillips
mcmcphillips previously approved these changes Jan 31, 2025
@ethankaplan ethankaplan merged commit be6c368 into develop Jan 31, 2025
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants