Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAT-7968 fixing few unnecessary async await when the API resposne is … #752

Merged
merged 14 commits into from
Jan 28, 2025

Conversation

RohitKandimalla
Copy link
Contributor

…being resolved

MADiE PR

Jira Ticket: MAT-0000
(Optional) Related Tickets:

Summary

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included.
  • No extemporaneous files are included (i.e Complied files or testing results).
  • This PR is merging into the correct branch.
  • All Documentation needed for this PR is Complete (or noted in a TODO or other Ticket).
  • Any breaking changes or failing automations are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package).
  • All CDN/Web dependencies are hosted internally (i.e MADiE-Root Repo).

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose.
  • The tests appropriately test the new code, including edge cases.
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads.

@RohitKandimalla RohitKandimalla self-assigned this Jan 21, 2025
@RohitKandimalla RohitKandimalla requested a review from a team as a code owner January 21, 2025 15:19
RohitKandimalla and others added 6 commits January 21, 2025 10:22
)

* MAT-7994: add indicator to criteria sub tabs

* MAT-7994: fix test

* MAT-7994: fix tests

* MAT-7994: fix tests

* MAT-7994: separate complete indicator into its own component

* MAT-7994: update completionIndicator

* MAT-7994: update tests

* MAT-7994: update tests
# Conflicts:
#	src/components/editMeasure/populationCriteria/groups/CompletionIndicator.tsx
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.

Project coverage is 83.09%. Comparing base (ad2a8cc) to head (bec9506).
Report is 15 commits behind head on develop.

Files with missing lines Patch % Lines
src/components/editMeasure/EditMeasure.tsx 55.55% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #752      +/-   ##
===========================================
- Coverage    83.10%   83.09%   -0.01%     
===========================================
  Files          312      312              
  Lines        11144    11141       -3     
  Branches      2427     2427              
===========================================
- Hits          9261     9258       -3     
  Misses        1300     1300              
  Partials       583      583              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RohitKandimalla RohitKandimalla merged commit 426f90b into develop Jan 28, 2025
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants