Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAT-7981] Package saved HR if available #37

Merged
merged 4 commits into from
Jan 14, 2025

Conversation

jkotanchik-SB
Copy link
Contributor

@jkotanchik-SB jkotanchik-SB commented Jan 14, 2025

MADiE PR

Jira Ticket: MAT-7981
(Optional) Related Tickets:

Summary

  • MAT-7981: If available, package the Human Readable from the Export object. Else, generate from Bundle content.
  • MAT-7981: Remove unused templates.
  • MAT-7981: Bump version.

All Submissions

  • This PR has the JIRA linked.
  • Required tests are included.
  • No extemporaneous files are included (i.e Complied files or testing results).
  • This PR is merging into the correct branch.
  • All Documentation needed for this PR is Complete (or noted in a TODO or other Ticket).
  • Any breaking changes or failing automations are noted by placing a comment on this PR.

DevSecOps

If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

  • This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package).

Reviewers

By Approving this PR you are attesting to the following:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose.
  • The tests appropriately test the new code, including edge cases.
  • If you have any concerns they are brought up either to the developer assigned, security engineer, or leads.

@jkotanchik-SB jkotanchik-SB self-assigned this Jan 14, 2025
@jkotanchik-SB jkotanchik-SB requested a review from a team January 14, 2025 18:58
Copy link

@sb-cecilialiu sb-cecilialiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there are test failures?

@jkotanchik-SB jkotanchik-SB force-pushed the feature/mat-7981-export-saved-human-readable branch from 220fcc7 to f657f84 Compare January 14, 2025 19:17
@jkotanchik-SB jkotanchik-SB merged commit fcb3a9b into develop Jan 14, 2025
6 checks passed
@jkotanchik-SB jkotanchik-SB deleted the feature/mat-7981-export-saved-human-readable branch January 14, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants