-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create README.md #4
base: master
Are you sure you want to change the base?
Conversation
Please squash-merge. |
... they are still valid, if new code is committed, resulting in different line numbers
and align with the ["Analysis of tar_git" document in Storeman's wiki](https://github.com/storeman-developers/harbour-storeman/wiki/Analysis-of-tar_git) and vice versa.
... because it was referenced in the section below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my point of view the docs look quite good.
However the readme looks more like a summary what the code exactly does rather than an explanation of the service specific options.
E.g. the explanation regarding source names doesn't belong here as it is general behavior of obs source services. A good example for a readme is the tar_scm service's readme.md.
A shorter version of what each option does should go to the service file of the service.
I am glad you like it. Also this write-up has proven to be useful for me multiple times now, saving a lot of time compared to having to analyse the code each time.
Basically "yes", because it is meant as a guide for users of As there are a few issues with the current behaviour of the service options, I expect rsp. hope that some details will change, thus this crude documentation is written close to the code with links to specific parts of it.
Oh, I have no idea what generic OBS behaviour is and what is But your statement implies that the section "Source archive name" is actually wrong, because it refers to Still I would prefer to keep this section in for now, because it describes one of the unexpected behaviours the Sailfish-OBS shows, when one uses it for the first time without prior OBS experience. For those the difference between generic OBS and May I suggest, that I rectify what is technically wrong if you clearly point out what is wrong in which way (e.g. by a "Yes" to my question above or a "No" with a little explanation), then you squash-merge this PR, because it constitutes a vast improvement over the current situation: no documentation at all. After that this README can be used as a starting point for enhancing it further, if someone has the energy and time (I don't). |
Based on the experiences documented in sailfishos-chum/main#77 (comment) ff.
The open <ToDo> WRT changelog extraction / processing is briefly, but not at all conclusively addressed in sailfishos-patches/patchmanager#327.
P.S.: A slightly extended version of this README is hosted as Analysis of
tar_git
in the Storeman wiki.