Merge Portlet UI Cleanup Meeds-io/MIPs#81 #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaraBoutej
changed the title
SaraBoutej
changed the title
SaraBoutej
force-pushed
the
merge-mip81-dev
branch
from
8857b50 to
ee3dc77
Compare
rdenarie
requested changes
Nov 13, 2023
| @@ -17,3 +17,4 @@ Modifications applied on imported libraries: | |||
| - .v-tabs--centered > .v-tabs-bar .v-tabs-slider-wrapper (centered tabs) doesn't use centered tabs because of bad usage of CSS priorities, thus !important is added to effectively center tabs | |||
| - delete '!important' from .v-card-flat:@box-shadow (line 22363) to avoid force disabling box-shadow on cards when using flat attribute on v-card | |||
| - Add fix on v-alert.prominent.dense icon size introduced in 2.4 | |||
| - Add @borderRadius with 5px instead of using 4px for defaut border radius | |||
There was a problem hiding this comment.
Suggested change
| - Add @borderRadius with 5px instead of using 4px for defaut border radius | |
| - Add @borderRadius with 4px instead of using 5px for defaut border radius |
There was a problem hiding this comment.
Suggested change
| - Add @borderRadius with 5px instead of using 4px for defaut border radius | |
| - Add @baseBorderRadius variable to use centralized border radius for Vuetify components |
@SaraBoutej we may need to delete the usage of @borderRadius here. In fact, the brandable @borderRadius should be used for applications parent DOM element only.
boubaker
reviewed
Nov 13, 2023
platform-ui-skin/src/main/webapp/skin/less/vuetify/lib/vuetify.less
Outdated
Show resolved
Hide resolved
boubaker
reviewed
Nov 13, 2023
platform-ui-skin/src/main/webapp/skin/less/vuetify/lib/vuetify.less
Outdated
Show resolved
Hide resolved
boubaker
reviewed
Nov 13, 2023
platform-ui-skin/src/main/webapp/skin/less/vuetify/lib/vuetify.less
Outdated
Show resolved
Hide resolved
boubaker
reviewed
Nov 13, 2023
platform-ui-skin/src/main/webapp/skin/less/vuetify/lib/vuetify.less
Outdated
Show resolved
Hide resolved
boubaker
reviewed
Nov 13, 2023
platform-ui-skin/src/main/webapp/skin/less/vuetify/lib/vuetify.less
Outdated
Show resolved
Hide resolved
boubaker
reviewed
Nov 13, 2023
platform-ui-skin/src/main/webapp/skin/less/vuetify/lib/vuetify.less
Outdated
Show resolved
Hide resolved
boubaker
reviewed
Nov 13, 2023
platform-ui-skin/src/main/webapp/skin/less/vuetify/lib/vuetify.less
Outdated
Show resolved
Hide resolved
boubaker
reviewed
Nov 13, 2023
platform-ui-skin/src/main/webapp/skin/less/vuetify/lib/vuetify.less
Outdated
Show resolved
Hide resolved
boubaker
reviewed
Nov 13, 2023
platform-ui-skin/src/main/webapp/skin/less/vuetify/lib/vuetify.less
Outdated
Show resolved
Hide resolved
boubaker
reviewed
Nov 13, 2023
platform-ui-skin/src/main/webapp/skin/less/vuetify/lib/vuetify.less
Outdated
Show resolved
Hide resolved
boubaker
reviewed
Nov 13, 2023
platform-ui-skin/src/main/webapp/skin/less/vuetify/lib/vuetify.less
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed!
|
|
Thanks @SaraBoutej . LGTM, I let @rdenarie continue the review. |
rdenarie
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.