feat: Margins cleanup - Remove extra-margins - MEED-2895-Meeds-io/MIPs#103 #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boubaker
approved these changes
Nov 14, 2023
boubaker
reviewed
Nov 14, 2023
Comment on lines
64
to
66
| .PORTLET-FRAGMENT { | ||
| margin-bottom: @applicationMarginBottom; | ||
| } |
There was a problem hiding this comment.
Suggested change
| .PORTLET-FRAGMENT { | |
| margin-bottom: @applicationMarginBottom; | |
| } | |
| .PORTLET-FRAGMENT { | |
| margin-bottom: @applicationMarginBottom; | |
| } |
boubaker
reviewed
Nov 14, 2023
| @@ -18,3 +18,4 @@ Modifications applied on imported libraries: | |||
| - delete '!important' from .v-card-flat:@box-shadow (line 22363) to avoid force disabling box-shadow on cards when using flat attribute on v-card | |||
| - Add fix on v-alert.prominent.dense icon size introduced in 2.4 | |||
| - Add @borderRadius with 5px instead of using 4px for defaut border radius | |||
| - Add @applicationMarginBottom with 20px to add a margin bottom for all portlets | |||
There was a problem hiding this comment.
Not needed as this will not affect Vuetify default style.
Suggested change
| - Add @applicationMarginBottom with 20px to add a margin bottom for all portlets |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows to remove all magrins added for Vue applications parents.
The margin will be added as a CSS variable inside the less variables, so we can change this variable using the branding UI.