New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge Margins management & cleanup Meeds-io/MIPs#103 #711

Merged

SaraBoutej merged 2 commits into develop from merge-mip103-develop

Nov 22, 2023

Contributor

SaraBoutej commented Nov 21, 2023

No description provided.

SaraBoutej added 2 commits

November 21, 2023 11:55


          feat: Margins cleanup - Remove extra-margins - MEED-2895-Meeds-io/MIP…

81ae4df

…s#103 (#708)

This change allows to remove all magrins added for Vue applications parents.
The margin will be added as a CSS variable inside the less variables, so we can change this variable using the branding UI.

(cherry picked from commit f060fdb)


          feat: Container margins managements - MEED-2867-Meeds-io/MIPs#103 (#709)

2c4a2e1

fix feedback

(cherry picked from commit 1563592)

github-actions bot added the partialCIBuild label

sonarqubecloud bot commented Nov 21, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

SaraBoutej requested a review from rdenarie

November 22, 2023 08:18

SaraBoutej self-assigned this

SaraBoutej mentioned this pull request

Margins management & cleanup Meeds-io/MIPs#103

Closed

rdenarie approved these changes

View reviewed changes

SaraBoutej merged commit d83a817 into develop

4 checks passed

SaraBoutej deleted the merge-mip103-develop branch

November 22, 2023 11:49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels