Gzip post data before sending to New Relic #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The newrelic plugin agent was running, but New Relic was not showing any data. Upon investigation, I was seeing this in the debug log:
DEBUG 2017-02-02 11:23:39,688 17393 MainProcess MainThread newrelic_plugin_agent.agent send_components L233 : Response: 413: '{"error": "Request size is over 1 MiB limit"}'I'm creating a lot of metrics with this plugin and New Relic has a hard limit of 1 MiB on POST data.
Gzipping the POST data with this patch took my POSTs from about 1.2 MB to 46 KB. New Relic is accepting and showing the metrics again.
Thanks for looking into this.