-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove KEGGREST
dependency
#113
base: master
Are you sure you want to change the base?
Conversation
devtools::check() passes locally on my mac, so I think the failing test is OK to ignore |
I'm not sure if this is a standard thing to do or necessary, but is there a way to include a reference to the KEGGREST function being the original inspiration besides in |
I'll include an |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran get_mol_kegg(c("C16181", "C00042"), dir = "temp_mols/")
from the main and this PR to compare the resulting mol files and they were the same.
This returns two mol files still, each with a name that is the compound id, but they both have the mol files for both compounds in each. Is that the desired behavior @Aariq?
Nope! They should be split. I'll take a look. Thanks for the example. |
I had a |
Closes #108 by accessing KEGG API directly with
httr2
(already a dependency) for getting mol files.