Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/cele 77 #51

Merged
merged 5 commits into from
Oct 9, 2024
Merged

Feature/cele 77 #51

merged 5 commits into from
Oct 9, 2024

Conversation

afonsobspinto
Copy link
Member

@afonsobspinto afonsobspinto commented Oct 1, 2024 •
edited
Loading

Closes https://metacell.atlassian.net/browse/CELE-77

  • Adds state variable to global context so we can track if rotation should be enabled
  • Adds useEffect on the global isRotating variable so workspaces can react to its changes
  • Fixes an issue I spotted with the viewer settings in compare mode (which was always getting the settings from the 'currentWorkspace' instead of the one selected)
2024-10-01.11-14-42.mp4

@afonsobspinto afonsobspinto marked this pull request as draft October 1, 2024 10:21
@afonsobspinto afonsobspinto marked this pull request as ready for review October 1, 2024 11:42
@afonsobspinto afonsobspinto requested a review from aranega October 1, 2024 11:42
@afonsobspinto afonsobspinto requested a review from aranega October 2, 2024 17:38
aranega
aranega approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@aranega aranega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@afonsobspinto Thanks a lot! 🙏 All looks good to me!

@afonsobspinto afonsobspinto changed the base branch from feature/CELE-95 to develop October 2, 2024 17:46
@aranega aranega merged commit 170bea9 into develop Oct 9, 2024
8 checks passed
@aranega aranega deleted the feature/CELE-77 branch October 9, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aranega aranega aranega approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@afonsobspinto @aranega