Feature/cele 119 #79
Merged
Feature/cele 119 #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aranega
reviewed
Jan 6, 2025
There was a problem hiding this comment.
@afonsobspinto I wonder if perhaps the issue you observed about buffering couldn't be partially impacted by the fact that the endpoint is not async (really not sure).
|
I think the niquests problem was somehow related with the 'Content-Encoding' header being set to 'gzip'. Using no compression seems to make the streaming go as expected: 2025-01-09.21-55-53.mp4 |
aranega
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes https://metacell.atlassian.net/browse/CELE-119
Adds new populate_db endpoint, secured by a custom authenticator that uses django authenticate to login the user with username and password and verifies if the user exists and is a superuser
Adds @with_stdout_streaming decorator that:
. Runs the decorated function in a separate thread
. Captures anything it prints to stdout,
. Streams that output asynchronously line-by-line as it's produced.
Updates ingestion script to trigger the database population (when the --populate-db flags is passed, we can also define the url via --populate-db-url") by using the gcp credentials to make a request to the aforementioned endpoint. Sub optimally, the request is made with curl via subprocess to surpass some buffering issues encountered when trying niquests (also happened with requests and httpx)
2024-12-19.11-51-46.mp4