Fix ESLint config (#5132) #14490

Fix ESLint config (#5132)

Usage Workflow file

4 errors and 11 warnings

Run yarn lint: packages/profile-sync-controller/src/controllers/user-storage/account-syncing/controller-integration.test.ts#L371

`it`s should begin with lowercase

Run yarn lint: packages/profile-sync-controller/src/controllers/user-storage/account-syncing/controller-integration.test.ts#L386

Use `toStrictEqual()` instead

Run yarn lint: packages/profile-sync-controller/src/controllers/user-storage/account-syncing/controller-integration.test.ts#L407

`it`s should begin with lowercase

Run yarn lint: packages/profile-sync-controller/src/controllers/user-storage/account-syncing/controller-integration.test.ts#L430

Use `toStrictEqual()` instead

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

Run yarn lint: examples/example-controllers/src/gas-prices-controller.test.ts#L5

`../../../packages/base-controller/tests/helpers` type import should occur after import of `./network-controller-types`

Run yarn lint: examples/example-controllers/src/gas-prices-controller.ts#L196

Member '#gasPricesService' is never reassigned; mark it as `readonly`

Run yarn lint: examples/example-controllers/src/gas-prices-controller.ts#L241

Replace `·await·this.#gasPricesService.fetchGasPrices(⏎······chainId,⏎····` with `⏎······await·this.#gasPricesService.fetchGasPrices(chainId`

Run yarn lint: examples/example-controllers/src/gas-prices-service/gas-prices-service.test.ts#L17

The 'fetch' is still an experimental feature and is not supported until Node.js 21.0.0. The configured version range is '^18.18 || >=20'

Run yarn lint: examples/example-controllers/src/gas-prices-service/gas-prices-service.ts#L41

Member '#fetch' is never reassigned; mark it as `readonly`

Run yarn lint: examples/example-controllers/src/gas-prices-service/gas-prices-service.ts#L56

Missing JSDoc @returns declaration

Run yarn lint: examples/example-controllers/src/pet-names-controller.test.ts#L8

`./pet-names-controller` type import should occur before type import of `../../../packages/base-controller/tests/helpers`

Run yarn lint: examples/example-controllers/src/pet-names-controller.test.ts#L9

`./pet-names-controller` import should occur before type import of `../../../packages/base-controller/tests/helpers`

Run yarn lint: packages/accounts-controller/src/AccountsController.test.ts#L18

No exported names found in module 'uuid'

Run yarn lint: packages/accounts-controller/src/AccountsController.test.ts#L140

Member '#accountIds' is never reassigned; mark it as `readonly`

succeeded Jan 14, 2025 in 1m 36s