Skip to content

Commit

Permalink
chore: Update codeowners to match EM agreed ownership (#4750)
Browse files Browse the repository at this point in the history 
## Explanation
We, the MetaMask team (holistically), have recently spent time
discussing code ownership around the packages in core. As a team we have
aligned on which teams own which packages/controllers within core. This
PR is to reflect that alignment. Additionally, in order to not make
releasing challenging for the Wallet Framework (who are the stewards of
the core repo) we have added this team as codeowners of the manifest
file and the changelog file for all packages.

For a little context being code owners doesn’t mean you are the only
ones who work in that code but rather that you will take responsibility
for making sure that the code is maintained, healthy, up to date and
that others contributing to it do so in a manner that is aligned with
our guidelines, processes and principles.

## References
- [Internal google sheets
doc](https://docs.google.com/spreadsheets/d/1fukzs7OBZBnswPTLysGaZO7I7uBOGYFpfXEK3Krkn5o/edit?usp=sharing)
teams used to align can be found in the google drive
- Additional discussions were in the #mmig-engineering-mgmt channel on
slack

## Checklist

- [ n/a ] I've updated the test suite for new or updated code as
appropriate
- [ n/a ] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [ n/a ] I've highlighted breaking changes using the "BREAKING"
category above as appropriate
- [ n/a ] I've prepared draft pull requests for clients and consumer
packages to resolve any breaking changes
  • Loading branch information
@desi
desi authored Oct 2, 2024
1 parent eecf907 commit 144f90f
Showing 1 changed file with 92 additions and 10 deletions.
102 changes: 92 additions & 10 deletions .github/CODEOWNERS
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,98 @@
# Each line is a file pattern followed by one or more owners.

* @MetaMask/engineering
/.github/ @MetaMask/wallet-framework-engineers

/packages/permission-controller @MetaMask/snaps-devs
/packages/notification-controller @MetaMask/snaps-devs
/packages/rate-limit-controller @MetaMask/snaps-devs
## Accounts Team
/packages/accounts-controller @MetaMask/accounts-engineers
/packages/keyring-controller @MetaMask/accounts-engineers
/packages/chain-controller @MetaMask/accounts-engineers

/packages/approval-controller @MetaMask/confirmations
/packages/gas-fee-controller @MetaMask/confirmations
/packages/message-manager @MetaMask/confirmations
/packages/name-controller @MetaMask/confirmations
/packages/signature-controller @MetaMask/confirmations
/packages/transaction-controller @MetaMask/confirmations
## Assets Team
/packages/assets-controller @MetaMask/metamask-assets

/packages/phishing-controller @MetaMask/product-safety
## Confirmations Team
/packages/address-book-controller @MetaMask/confirmations
/packages/approval-controller @MetaMask/confirmations
/packages/ens-controller @MetaMask/confirmations
/packages/gas-fee-controller @MetaMask/confirmations
/packages/logging-controller @MetaMask/confirmations
/packages/message-manager @MetaMask/confirmations
/packages/name-controller @MetaMask/confirmations
/packages/signature-controller @MetaMask/confirmations
/packages/transaction-controller @MetaMask/confirmations
/packages/user-operation-controller @MetaMask/confirmations

## Notifications Team
/packages/notification-services-controller @MetaMask/notifications
/packages/profile-sync-controller @MetaMask/notifications

## Product Safety Team
/packages/phishing-controller @MetaMask/product-safety

## Snaps Team
/packages/notification-controller @MetaMask/snaps-devs
/packages/rate-limit-controller @MetaMask/snaps-devs

## Wallet API Platform Team
/packages/queued-request-controller @MetaMask/wallet-api-platform-engineers

## Wallet Framework Team
/packages/base-controller @MetaMask/wallet-framework-engineers
/packages/build-utils @MetaMask/wallet-framework-engineers
/packages/composable-controller @MetaMask/wallet-framework-engineers
/packages/controller-utils @MetaMask/wallet-framework-engineers
/packages/polling-controller @MetaMask/wallet-framework-engineers
/packages/preferences-controller @MetaMask/wallet-framework-engineers

## Wallet UX Team
/packages/announcement-controller @MetaMask/wallet-ux

## Joint team ownership
/packages/eth-json-rpc-provider @MetaMask/wallet-api-platform-engineers @MetaMask/wallet-framework-engineers
/packages/json-rpc-engine @MetaMask/wallet-api-platform-engineers @MetaMask/wallet-framework-engineers
/packages/json-rpc-middleware-stream @MetaMask/wallet-api-platform-engineers @MetaMask/wallet-framework-engineers
/packages/network-controller @MetaMask/wallet-framework-engineers @MetaMask/metamask-assets
/packages/permission-controller @MetaMask/wallet-api-platform-engineers @MetaMask/wallet-framework-engineers @MetaMask/snaps-devs
/packages/permission-log-controller @MetaMask/wallet-api-platform-engineers @MetaMask/wallet-framework-engineers
/packages/selected-network-controller @MetaMask/wallet-api-platform-engineers @MetaMask/wallet-framework-engineers @MetaMask/metamask-assets

## Package Release related
/packages/accounts-controller/package.json @MetaMask/accounts-engineers @MetaMask/wallet-framework-engineers
/packages/accounts-controller/CHANGELOG.md @MetaMask/accounts-engineers @MetaMask/wallet-framework-engineers
/packages/address-book-controller/package.json @MetaMask/confirmations @MetaMask/wallet-framework-engineers
/packages/address-book-controller/CHANGELOG.md @MetaMask/confirmations @MetaMask/wallet-framework-engineers
/packages/announcement-controller/package.json @MetaMask/wallet-ux @MetaMask/wallet-framework-engineers
/packages/announcement-controller/CHANGELOG.md @MetaMask/wallet-ux @MetaMask/wallet-framework-engineers
/packages/approval-controller/package.json @MetaMask/confirmations @MetaMask/wallet-framework-engineers
/packages/approval-controller/CHANGELOG.md @MetaMask/confirmations @MetaMask/wallet-framework-engineers
/packages/assets-controller/package.json @MetaMask/metamask-assets @MetaMask/wallet-framework-engineers
/packages/assets-controller/CHANGELOG.md @MetaMask/metamask-assets @MetaMask/wallet-framework-engineers
/packages/ens-controller/package.json @MetaMask/confirmations @MetaMask/wallet-framework-engineers
/packages/ens-controller/CHANGELOG.md @MetaMask/confirmations @MetaMask/wallet-framework-engineers
/packages/gas-fee-controller/package.json @MetaMask/confirmations @MetaMask/wallet-framework-engineers
/packages/gas-fee-controller/CHANGELOG.md @MetaMask/confirmations @MetaMask/wallet-framework-engineers
/packages/keyring-controller/package.json @MetaMask/accounts-engineers @MetaMask/wallet-framework-engineers
/packages/keyring-controller/CHANGELOG.md @MetaMask/accounts-engineers @MetaMask/wallet-framework-engineers
/packages/logging-controller/package.json @MetaMask/confirmations @MetaMask/wallet-framework-engineers
/packages/logging-controller/CHANGELOG.md @MetaMask/confirmations @MetaMask/wallet-framework-engineers
/packages/message-manager/package.json @MetaMask/confirmations @MetaMask/wallet-framework-engineers
/packages/message-manager/CHANGELOG.md @MetaMask/confirmations @MetaMask/wallet-framework-engineers
/packages/name-controller/package.json @MetaMask/confirmations @MetaMask/wallet-framework-engineers
/packages/name-controller/CHANGELOG.md @MetaMask/confirmations @MetaMask/wallet-framework-engineers
/packages/notification-controller/package.json @MetaMask/snaps-devs @MetaMask/wallet-framework-engineers
/packages/notification-controller/CHANGELOG.md @MetaMask/snaps-devs @MetaMask/wallet-framework-engineers
/packages/notification-services-controller/package.json @MetaMask/notifications @MetaMask/wallet-framework-engineers
/packages/notification-services-controller/CHANGELOG.md @MetaMask/notifications @MetaMask/wallet-framework-engineers
/packages/profile-sync-controller/package.json @MetaMask/notifications @MetaMask/wallet-framework-engineers
/packages/profile-sync-controller/CHANGELOG.md @MetaMask/notifications @MetaMask/wallet-framework-engineers
/packages/queued-request-controller/package.json @MetaMask/wallet-api-platform-engineers @MetaMask/wallet-framework-engineers
/packages/queued-request-controller/CHANGELOG.md @MetaMask/wallet-api-platform-engineers @MetaMask/wallet-framework-engineers
/packages/signature-controller/package.json @MetaMask/confirmations @MetaMask/wallet-framework-engineers
/packages/signature-controller/CHANGELOG.md @MetaMask/confirmations @MetaMask/wallet-framework-engineers
/packages/rate-limit-controller/package.json @MetaMask/snaps-devs @MetaMask/wallet-framework-engineers
/packages/rate-limit-controller/CHANGELOG.md @MetaMask/snaps-devs @MetaMask/wallet-framework-engineers
/packages/transaction-controller/package.json @MetaMask/confirmations @MetaMask/wallet-framework-engineers
/packages/transaction-controller/CHANGELOG.md @MetaMask/confirmations @MetaMask/wallet-framework-engineers
/packages/user-operation-controller/package.json @MetaMask/confirmations @MetaMask/wallet-framework-engineers
/packages/user-operation-controller/CHANGELOG.md @MetaMask/confirmations @MetaMask/wallet-framework-engineers

0 comments on commit 144f90f

Please sign in to comment.